Skip to content

Added bookmark block #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2020
Merged

Added bookmark block #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7003cc4
Added bookmark block
el-angel Apr 21, 2020
dfcc34f
Removed inner div
el-angel Apr 23, 2020
353dcff
removed another inner div
el-angel Apr 23, 2020
ffeb77d
Minimized css and html
el-angel Apr 23, 2020
195b7c6
Merge remote-tracking branch 'origin/master' into fork/add-bookmark-b…
timolins Apr 27, 2020
ed720b1
Add className & text content utilities
timolins Apr 27, 2020
d57316d
Improve bookmark styling
timolins Apr 27, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,39 @@ export const Block: React.FC<Block> = props => {
</div>
</div>
);
case "bookmark":
return (
<div className="notion-row">
<a
target="_blank"
rel="noopener noreferrer"
className="notion-bookmark"
href={blockValue.properties.link[0][0]}
>
<div role="button" className="notion-bookmark-inner">
<div>
<div className="notion-bookmark-title">
{renderChildText(blockValue.properties.title)}
</div>
<div className="notion-bookmark-description">
{renderChildText(blockValue.properties.description)}
</div>
<div className="notion-bookmark-link">
<img src={blockValue.format.bookmark_icon} />
<div>{renderChildText(blockValue.properties.link)}</div>
</div>
</div>
<div>
<div>
<div>
<img src={blockValue.format.bookmark_cover} />
</div>
</div>
</div>
Copy link
Member

@tobiaslins tobiaslins Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need so many nested div's here :)
Copy link
Contributor Author

@el-angel el-angel Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied all the css from notion yes, and also their html markup. I'll minimize it! :)
</div>
</a>
</div>
);
default:
if (process.env.NODE_ENV !== "production") {
console.log("Unsupported type " + block?.value?.type);
Expand Down
103 changes: 103 additions & 0 deletions src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,110 @@ h3 {
display: flex;
}

.notion-bookmark {
display: block;
color: inherit;
text-decoration: none;
flex-grow: 1;
min-width: 0px;
}

.notion-bookmark-inner {
user-select: none;
transition: background 120ms ease-in 0s;
cursor: pointer;
width: 100%;
display: flex;
flex-wrap: wrap-reverse;
align-items: stretch;
text-align: left;
overflow: hidden;
border: 1px solid rgba(55, 53, 47, 0.16);
border-radius: 3px;
position: relative;
color: inherit;
fill: inherit;
}

.notion-bookmark-inner > div:first-child {
flex: 4 1 180px;
padding: 12px 14px 14px;
overflow: hidden;
text-align: left;
}

.notion-bookmark-title {
font-size: 14px;
line-height: 20px;
color: rgb(55, 53, 47);
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
min-height: 24px;
margin-bottom: 2px;
}

.notion-bookmark-description {
font-size: 12px;
line-height: 16px;
color: rgba(55, 53, 47, 0.6);
height: 32px;
overflow: hidden;
}

.notion-bookmark-link {
display: flex;
margin-top: 6px;
}

.notion-bookmark-link > img {
width: 16px;
height: 16px;
min-width: 16px;
margin-right: 6px;
}

.notion-bookmark-link > div {
font-size: 12px;
line-height: 16px;
color: rgb(55, 53, 47);
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}

.notion-bookmark-inner > div:last-child {
flex: 1 1 180px;
display: block;
position: relative;
}

.notion-bookmark-inner > div:last-child > div {
position: absolute;
top: 0px;
left: 0px;
right: 0px;
bottom: 0px;
}

.notion-bookmark-inner > div:last-child > div > div {
width: 100%;
height: 100%;
}

.notion-bookmark-inner > div:last-child img {
display: block;
object-fit: cover;
border-radius: 1px;
width: 100%;
height: 100%;
}

@media (max-width: 640px) {
.notion-bookmark-inner > div:last-child {
display: none;
}

.notion-row {
flex-direction: column;
}
Expand Down
16 changes: 15 additions & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,19 @@ export interface BaseTextValueType extends BaseValueType {
};
}

interface BookmarkValueType extends BaseValueType {
type: "bookmark";
properties: {
link: DecorationType[];
title: DecorationType[];
description: DecorationType[];
};
format: {
bookmark_icon: string;
bookmark_cover: string;
};
}

interface TextValueType extends BaseTextValueType {
type: "text";
}
Expand Down Expand Up @@ -223,7 +236,8 @@ export type BlockValueType =
| ImageValueType
| VideoValueType
| EmbedValueType
| CalloutValueType;
| CalloutValueType
| BookmarkValueType;

export interface BlockType {
role: string;
Expand Down