Added bookmark block #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tobiaslins reviewed Apr 23, 2020
Member
tobiaslins left a comment
tobiaslins left a comment There was a problem hiding this comment.
Cool thank you!
Is the HTML/CSS from Notion directly?
I think we can minimize the HTML & CSS there!
src/block.tsx Outdated
Comment on lines 204 to 210
| <div> | ||
| <div> | ||
| <div> | ||
| <img src={blockValue.format.bookmark_cover} /> | ||
| </div> | ||
| </div> | ||
| </div> |
Member
There was a problem hiding this comment.
I think we don't need so many nested div's here :)
Contributor Author
There was a problem hiding this comment.
I copied all the css from notion yes, and also their html markup. I'll minimize it! :)
- Hide image when inside column - Add support for custom background colors - Add alt tags to images
Member
| Looking good! 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cool package! Thought I'd take a look at the bookmark block. :)