Remove incorrect assertions (#14204)

Author: AA-Turner

CHANGES.rst

@@ -28,6 +28,8 @@ Bugs fixed
  Patch by Adam Turner
 * #14089: autodoc: Fix default option parsing.
  Patch by Adam Turner
+* Remove incorrect static typing assertions.
+ Patch by Adam Turner
 
 Testing
 -------

sphinx/directives/__init__.py

@@ -215,7 +215,7 @@ def run(self) -> list[Node]:
  # note_source uses 0-based line numbers.
  if line is not None:
  line -= 1
- self.state.document.note_source(source, line)
+ self.state.document.note_source(source, line) # type: ignore[arg-type]
  node['domain'] = self.domain
  # 'desctype' is a backwards compatible attribute
  node['objtype'] = node['desctype'] = self.objtype

sphinx/ext/autodoc/directive.py

@@ -71,7 +71,7 @@ def __init__(
  env: BuildEnvironment,
  reporter: Reporter | None,
  options: Options,
- lineno: int,
+ lineno: int | None,
  state: Any,
  ) -> None:
  self.env = env

sphinx/util/docutils.py

@@ -500,14 +500,12 @@ def config(self) -> Config:
  """
  return self.env.config
 
- def get_source_info(self) -> tuple[str, int]:
+ def get_source_info(self) -> tuple[str | None, int | None]:
  """Get source and line number.
 
  .. versionadded:: 3.0
  """
  source, line = self.state_machine.get_source_and_line(self.lineno)
- assert source is not None
- assert line is not None
  return source, line
 
  def set_source_info(self, node: Node) -> None:
@@ -681,18 +679,20 @@ def config(self) -> Config:
  """
  return self.env.config
 
- def get_source_info(self, lineno: int | None = None) -> tuple[str, int]:
+ def get_source_info(
+ self, lineno: int | None = None
+ ) -> tuple[str | os.PathLike[str] | None, int | None]:
  # .. versionadded:: 3.0
  if lineno is None:
  lineno = self.lineno
  source, line = self.inliner.reporter.get_source_and_line(lineno)
- assert source is not None
- assert line is not None
- return str(source), line
+ return source, line
 
  def set_source_info(self, node: Node, lineno: int | None = None) -> None:
  # .. versionadded:: 2.0
- node.source, node.line = self.get_source_info(lineno)
+ source, line = self.get_source_info(lineno)
+ node.source = str(source) if source is not None else None
+ node.line = line
 
  def get_location(self) -> str:
  """Get current location info for logging.