[Java] Fix bug in DTO decodeFrom signature.

It was using `short` for `actingVersion` and `blockLength`, but the inner call to `Decoder#wrap` expects an `int` (in the `uint16` range) for both arguments. There were a bunch of down/narrowing casts in tests, which I should have spotted when doing the port and have now been removed.

Author: ZachBray

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/java/JavaDtoGenerator.java

@@ -470,7 +470,7 @@ private static void generateDecodeFrom(
  .append("\n")
  .append(indent).append("public static ").append(dtoClassName).append(" decodeFrom(")
  .append("DirectBuffer buffer, int offset, ")
- .append("short actingBlockLength, short actingVersion)\n")
+ .append("int actingBlockLength, int actingVersion)\n")
  .append(indent).append("{\n")
  .append(indent).append(INDENT).append(decoderClassName).append(" decoder = new ")
  .append(decoderClassName).append("();\n")

sbe-tool/src/propertyTest/java/uk/co/real_logic/sbe/properties/DtosPropertyTest.java

@@ -101,16 +101,16 @@ void javaDtoEncodeShouldBeTheInverseOfDtoDecode(
  generatedClassLoader.loadClass(packageName + ".TestMessageDto");
 
  final Method decodeFrom =
- dtoClass.getMethod("decodeFrom", DirectBuffer.class, int.class, short.class, short.class);
+ dtoClass.getMethod("decodeFrom", DirectBuffer.class, int.class, int.class, int.class);
 
  final Method encodeWith =
  dtoClass.getMethod("encodeWithHeaderWith", dtoClass, MutableDirectBuffer.class, int.class);
 
  final int inputLength = encodedMessage.length();
  final ExpandableArrayBuffer inputBuffer = encodedMessage.buffer();
  final MessageHeaderDecoder header = new MessageHeaderDecoder().wrap(inputBuffer, 0);
- final short blockLength = (short)header.blockLength();
- final short actingVersion = (short)header.version();
+ final int blockLength = header.blockLength();
+ final int actingVersion = header.version();
  final Object dto = decodeFrom.invoke(null,
  encodedMessage.buffer(), MessageHeaderDecoder.ENCODED_LENGTH, blockLength, actingVersion);
  outputBuffer.setMemory(0, outputBuffer.capacity(), (byte)0);

sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/java/DtoTest.java

@@ -56,8 +56,7 @@ void shouldRoundTripCar2()
  final ExpandableArrayBuffer inputBuffer = new ExpandableArrayBuffer();
  final int inputLength = encodeCar(inputBuffer, 0);
 
- final CarDto dto =
- CarDto.decodeFrom(inputBuffer, 0, (short)CarDecoder.BLOCK_LENGTH, (short)CarDecoder.SCHEMA_VERSION);
+ final CarDto dto = CarDto.decodeFrom(inputBuffer, 0, CarDecoder.BLOCK_LENGTH, CarDecoder.SCHEMA_VERSION);
 
  final ExpandableArrayBuffer outputBuffer = new ExpandableArrayBuffer();
  final int outputLength = CarDto.encodeWith(dto, outputBuffer, 0);