Skip to content

Commit befac6a

Browse files
Move diff-circular-deps to dedicated script (KittyCAD#6123)
* Move diff-circular-deps to dedicated script * Update package.json Co-authored-by: Jace Browning <jacebrowning@gmail.com> * Fix ci --------- Co-authored-by: Jace Browning <jacebrowning@gmail.com>
1 parent 60bc385 commit befac6a

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.github/workflows/static-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ jobs:
164164
mkdir rust/kcl-lib/bindings
165165
cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/
166166
167-
- run: yarn diff-circular-deps
167+
- run: yarn circular-deps:diff
168168

169169
python-codespell:
170170
runs-on: ubuntu-22.04

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@
103103
"lint-fix": "eslint --fix --ext .ts --ext .tsx src e2e packages/codemirror-lsp-client/src rust/kcl-language-server/client/src",
104104
"lint": "eslint --max-warnings 0 --ext .ts --ext .tsx src e2e packages/codemirror-lsp-client/src rust/kcl-language-server/client/src",
105105
"circular-deps": "dpdm --no-warning --no-tree -T --skip-dynamic-imports=circular src/index.tsx",
106-
"diff-circular-deps": "yarn circular-deps | sed '$d' | grep -v '^yarn run' | tr -d '\n' > /tmp/circular-deps.txt && diff -w /tmp/circular-deps.txt ./known-circular.txt",
106+
"circular-deps:diff": "./scripts/diff-circular-deps.sh",
107107
"files:set-version": "echo \"$(jq --arg v \"$VERSION\" '.version=$v' package.json --indent 2)\" > package.json",
108108
"files:set-notes": "./scripts/set-files-notes.sh",
109109
"files:flip-to-nightly": "./scripts/flip-files-to-nightly.sh",

scripts/diff-circular-deps.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
#!/bin/bash
2+
set -euo pipefail
3+
4+
yarn circular-deps | sed '$d' | grep -v '^yarn run' | tr -d '\n' > /tmp/circular-deps.txt
5+
diff -w /tmp/circular-deps.txt ./known-circular.txt

0 commit comments

Comments
 (0)