Skip to content

Commit 820082d

Browse files
franknoirotgraphite-app[bot]nadr0
authored
Make onboarding optional, able to be ignored on desktop (KittyCAD#6564)
* Remove unused `telemetryLoader` * Remove onboarding redirect behavior * Allow subRoute to be passed to navigateToProject * Replace warning dialog routes with toasts * Wire up new utilities and toasts to UI components * Add home sidebar buttons for tutorial flow * Rename menu item * Add flex-1 so home-layout fills available space * Remove onboarding avatar tests, they are becoming irrelevant * Consolidate onboarding tests to one longer one and update it to not use pixel color checks, and use fixtures. * Shorten warning toast button text * tsc, lint, and circular deps * Update circular dep file * Fix mistakes made in circular update tweaking * One more dumb created circular dep * Update src/routes/Onboarding/utils.tsx Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> * Fix narrow screen home layout breaking * fix: kevin, navigation routes fixed * fix: filename parsing is correct now for onboarding with the last file sep * Fix e2e test state checks that are diff on Linux * Create onboarding project entirely through systemIOMachine * Fix Windows path construction --------- Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Co-authored-by: Kevin Nadro <kevin@zoo.dev>
1 parent 525f213 commit 820082d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+809
-1026
lines changed

e2e/playwright/fixtures/homePageFixture.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export class HomePageFixture {
2424
projectTextName!: Locator
2525
sortByDateBtn!: Locator
2626
sortByNameBtn!: Locator
27+
tutorialBtn!: Locator
2728

2829
constructor(page: Page) {
2930
this.page = page
@@ -43,6 +44,7 @@ export class HomePageFixture {
4344

4445
this.sortByDateBtn = this.page.getByTestId('home-sort-by-modified')
4546
this.sortByNameBtn = this.page.getByTestId('home-sort-by-name')
47+
this.tutorialBtn = this.page.getByTestId('home-tutorial-button')
4648
}
4749

4850
private _serialiseSortBy = async (): Promise<

e2e/playwright/fixtures/toolbarFixture.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ type LengthUnitLabel = (typeof baseUnitLabels)[keyof typeof baseUnitLabels]
1717
export class ToolbarFixture {
1818
public page: Page
1919

20+
projectName!: Locator
21+
fileName!: Locator
2022
extrudeButton!: Locator
2123
loftButton!: Locator
2224
sweepButton!: Locator
@@ -53,6 +55,8 @@ export class ToolbarFixture {
5355
constructor(page: Page) {
5456
this.page = page
5557

58+
this.projectName = page.getByTestId('app-header-project-name')
59+
this.fileName = page.getByTestId('app-header-file-name')
5660
this.extrudeButton = page.getByTestId('extrude')
5761
this.loftButton = page.getByTestId('loft')
5862
this.sweepButton = page.getByTestId('sweep')

e2e/playwright/native-file-menu.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ test.describe(
450450
)
451451
await expect(actual).toBeVisible()
452452
})
453-
test('Home.Help.Reset onboarding', async ({
453+
test('Home.Help.Replay onboarding tutorial', async ({
454454
tronApp,
455455
cmdBar,
456456
page,
@@ -464,7 +464,7 @@ test.describe(
464464
await tronApp.electron.evaluate(async ({ app }) => {
465465
if (!app || !app.applicationMenu) return false
466466
const menu = app.applicationMenu.getMenuItemById(
467-
'Help.Reset onboarding'
467+
'Help.Replay onboarding tutorial'
468468
)
469469
if (!menu) {
470470
return false
@@ -2339,7 +2339,7 @@ test.describe(
23392339
await scene.connectionEstablished()
23402340
await expect(toolbar.startSketchBtn).toBeVisible()
23412341
})
2342-
test('Modeling.Help.Reset onboarding', async ({
2342+
test('Modeling.Help.Replay onboarding tutorial', async ({
23432343
tronApp,
23442344
cmdBar,
23452345
page,
@@ -2358,7 +2358,7 @@ test.describe(
23582358
await tronApp.electron.evaluate(async ({ app }) => {
23592359
if (!app || !app.applicationMenu) fail()
23602360
const menu = app.applicationMenu.getMenuItemById(
2361-
'Help.Reset onboarding'
2361+
'Help.Replay onboarding tutorial'
23622362
)
23632363
if (!menu) fail()
23642364
menu.click()

0 commit comments

Comments
 (0)