Skip to content

Commit 7fce38b

Browse files
adamchalmersjtran
andauthored
KCL: angledLineThatIntersects migrate to kwargs (KittyCAD#6296)
* KCL: Convert angledLineThatIntersects to use kwargs * Update KCL tests and samples * WIP * Fix tsc and lint errors * Fix missing cases * Fix modifyAst unit tests * Fix sketch unit tests * Fix std unit tests * Fix to not have extra docs * Fix more unit tests * Fix bench test * Fix e2e tests to use new kw args * tiny lint * Fix adding constraint from UI to work * Fix to use labeledArg constraints and use the correct order of args * Fix selections e2e test * Fix e2e test expectation App was working as expected, but the e2e test was expecting the old code, not the new code. * Fix order of constraints in unit test * Update docs * Fix KCL formatting * Update output --------- Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
1 parent d0e9b11 commit 7fce38b

27 files changed

+5296
-657
lines changed

docs/kcl/angledLineThatIntersects.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ Draw an angled line from the current origin, constructing a line segment such th
1010

1111
```js
1212
angledLineThatIntersects(
13-
data: AngledLineThatIntersectsData,
1413
sketch: Sketch,
14+
angle: number,
15+
intersectTag: TagIdentifier,
16+
offset?: number,
1517
tag?: TagDeclarator,
1618
): Sketch
1719
```
@@ -21,9 +23,11 @@ angledLineThatIntersects(
2123

2224
| Name | Type | Description | Required |
2325
|----------|------|-------------|----------|
24-
| `data` | [`AngledLineThatIntersectsData`](/docs/kcl/types/AngledLineThatIntersectsData) | Data for drawing an angled line that intersects with a given line. | Yes |
25-
| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) | | Yes |
26-
| [`tag`](/docs/kcl/types/tag) | [`TagDeclarator`](/docs/kcl/types#tag-declaration) | | No |
26+
| `sketch` | [`Sketch`](/docs/kcl/types/Sketch) | Which sketch should this path be added to? | Yes |
27+
| `angle` | [`number`](/docs/kcl/types/number) | Which angle should the line be drawn at? | Yes |
28+
| `intersectTag` | [`TagIdentifier`](/docs/kcl/types#tag-identifier) | The tag of the line to intersect with | Yes |
29+
| `offset` | [`number`](/docs/kcl/types/number) | The offset from the intersecting line. Defaults to 0. | No |
30+
| [`tag`](/docs/kcl/types/tag) | [`TagDeclarator`](/docs/kcl/types#tag-declaration) | Create a new tag which refers to this line | No |
2731

2832
### Returns
2933

@@ -38,11 +42,7 @@ exampleSketch = startSketchOn(XZ)
3842
|> line(endAbsolute = [5, 10])
3943
|> line(endAbsolute = [-10, 10], tag = $lineToIntersect)
4044
|> line(endAbsolute = [0, 20])
41-
|> angledLineThatIntersects({
42-
angle = 80,
43-
intersectTag = lineToIntersect,
44-
offset = 10
45-
}, %)
45+
|> angledLineThatIntersects(angle = 80, intersectTag = lineToIntersect, offset = 10)
4646
|> close()
4747

4848
example = extrude(exampleSketch, length = 10)

0 commit comments

Comments
 (0)