Skip to content

Conversation

@Ecco
Copy link

@Ecco Ecco commented Mar 28, 2012

The code is still relying on a private API, and could therefore break again in the future.

A cleaner patch would be to only use documented APIs.

This is relying on a private API, and could therefore break again in the future.
@ioquatix
Copy link
Member

Fantastic, let me review the patch - I've been hoping that someone would work on this, I've been so busy..

@ioquatix
Copy link
Member

Here is a link to the Ruby bug report: http://bugs.ruby-lang.org/issues/4788

@Ecco
Copy link
Author

Ecco commented Mar 28, 2012

The patch is actually dead simple as you can see. I don't know wether it introduces any regression, but at the very least it did fix the simple server example :-)

And indeed your patch against Ruby sure would be a cleaner way, but in the meantime I think it's worth it to offer a quick fix :-) Ruby 1.9 is gaining momentum. Actually many people even consider 1.8 obsolete.

@jessedearing
Copy link

I suggest wrapping the call to make_udp_requester in a conditional that checks the RUBY_VERSION.

if RUBY_VERSION >= '1.9.3' requester = make_udp_requester else requester = make_requester end

I did that on a money patch I did for a 1.9.3 script before I saw this PR.

@ioquatix
Copy link
Member

Hi Jesse, thanks for that. I found some other issues when running with 1.9.3 so I'm just working on those now, then hopefully we'll have a 0.4.0 release =)

@ioquatix
Copy link
Member

This issue should be resolved in version 0.4.0.

@ioquatix ioquatix closed this Jun 11, 2012
@ioquatix
Copy link
Member

Thanks for everyone's detective work. Please migrate your RubyDNS scripts to 0.4.0 and let me know if you have any issues.

@ioquatix
Copy link
Member

PLEASE NOTE: Scripts that worked with 0.3.x won't work without a few minor changes with 0.4.x. Please check the migration notes in the README.md.

@ghost ghost assigned ioquatix Jun 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants