Skip to content

Conversation

@klarrimore
Copy link
Contributor

This is a fix for the timeout in Request. Requests would timeout even after they succeeded. With this method, when a Request times out it calls :fail then calls for try_next_server!. This new method caused an issue where the Request no longer closed the connect because before everyone request "timed out" and called try_next_server! which has this at the top:

 def try_next_server! if @request @request.close_connection @request = nil end 

so I added close_connection inside :recieve_data

@ioquatix
Copy link
Member

ioquatix commented Oct 8, 2013

Okay, I have integrated these changes, and released gem version 0.6.6 - let me know if this resolves the issues you were having.

@ioquatix ioquatix closed this Oct 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants