Added a :sequence_max to options for Resolver #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Hi, this looks like a good change. Do you think it makes sense just to hard code the limit as I'm sure that the sequence number must be |
Contributor Author
| Yes, i believe you're right. At first i thought it was overflow server side but I think the protocol just has 2 bytes allocated for the id. 2^16 should work for all cases. something like: |
Member
| Okay, I have integrated these changes, and released gem version 0.6.6 - let me know if this resolves the issues you were having. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have some issues with DNS Servers rolling their response id at 65536. RubyDNS's continues incrementing regardless and causes an obvious issue. Also git ignoring test log files and lowered the log level on responses.