Fix potential null exception on TCP requests #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Looks great, however in what cases is |
ioquatix added a commit that referenced this pull request Mar 31, 2013
Fix potential null exception on TCP requests
Member
| Thanks for the bug fix. I may edit this function a bit further to tidy it up. It looks like I've gone through several iterations of the logic without refactoring the overall code. |
Member
| I have release a new gem with this update included, v0.6.1 |
ioquatix added a commit that referenced this pull request Oct 23, 2014
Fix potential null exception on TCP requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was often getting errors when using the System::nameservers
(~/dev/ruby_gem/rubydns/lib/rubydns/resolver.rb:226:in
receive_data': undefined method+' for nil:NilClass (NoMethodError))