Skip to content

Conversation

@rrjbca
Copy link
Contributor

@rrjbca rrjbca commented Sep 3, 2021

Description

An incompatibility with the astropy development branch was recently caught by our compatibility workflow but the failure was not noticed or acted on by developers before it was released. This pull request adds a status badge for the compatibility workflow to the README to increase the visibility of failures for developers.

Checklist

  • Follow the Contributor Guidelines
  • Write unit tests
  • Write documentation strings
  • Assign someone from your working team to review this pull request
  • Assign someone from the infrastructure team to review this pull request
@rrjbca rrjbca added documentation Improvements or additions to documentation infrastructure continuous integration labels Sep 3, 2021
@rrjbca rrjbca requested a review from a team September 3, 2021 11:56
@Lucia-Fonseca
Copy link
Member

The badge is to increase the visibility of failures for developers but it will also be visible for the public. Do we really want that? Or it is not important?

@rrjbca
Copy link
Contributor Author

rrjbca commented Sep 6, 2021

The results of the compatibility workflow are already public: https://github.com/skypyproject/skypy/actions/workflows/compatibility.yaml

Copy link
Member

@Lucia-Fonseca Lucia-Fonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good.

@rrjbca rrjbca merged commit 8b95ecb into skypyproject:main Sep 7, 2021
@rrjbca rrjbca deleted the compatibility branch September 7, 2021 13:11
itrharrison added a commit that referenced this pull request Dec 15, 2022
* Update name of default branch to main (#434) * update mailmap (#432) * Write all tables to a single FITS/HDF5 file (#425) * ADR 3: Position sampling and patches of the sky (#422) * BUG: Raise ImportError if optional dependency speclite is not installed (#437) * MAINT: Set NumPy latest supported version to 1.20 #440 * Update status badges (#441) * MAINT: Update Lucia affiliation (#451) * MAINT: add SIT's information (#450) * DOC: Fix contributor guidelines link (#449) Co-authored-by: Richard R <58728519+rrjbca@users.noreply.github.com> Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk> * ENH: Logging for skypy command line script and Pipeline class (#453) * DOC: Describe speclite filters in documentation (#457) * ENH: Config syntax for importing objects (#463) * DOC: List of Features (#456) * DOC: How to construct config files (#454) * DOC: Remove docstring examples (#429) * MAINT: Update Zenodo entry for RPR (#468) * DOC: Readme updates (#460) * DOC: Expanded landing page documentation (#228) * DOC: Inverse transform sampling accuracy warning (#472) * MAINT: Set astropy latest supported version to 4.2 (#483) * DOC: zenodo json members update (#481) * DOC: Ryden04 ellipticity doc missing section (#477) * MAINT: Update numpy and scipy latest supported versions (#488) * BUG: Change invalid ecsv datatype from int to uint16 (#485) * DEV: setuptools==58.0.0 (#493) Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk> * Add compatibility workflow badge (#487) * DEV: Enable pip to install pre-releases in the tox dev environments (#491) * TST: Use tmp_path fixture for temporary files in unit tests (#489) * BUG: Move handling of context arguments after handling of .depends keyword (#465) * BLD: Set astropy latest supported version to 4.3 and speclite minversion to 0.14 (#486) * REV: restore setuptools to latest version on readthedocs (#494) * DEV: pyparsing<3.0.0 (#500) * Check new astropy file overwrite error message in logging test (#498) * REV: restore pyparsing to latest version for doc builds (#501) * DOC: Update citation file with JOSS paper reference (#496) * BLD: Set astropy latest supported version to 5.0 (#504) * BLD: Set python latest supported version to 3.10 (#505) * BLD: Set numpy latest supported version to 1.22 (#506) * BLD: Set python oldest supported version to 3.7 (#507) * DOC: Fix code of conduct link (#508) * Changed y-label in luminosity function example. (#512) * BLD: Set scipy latest supported version to 1.8 (#510) * ENH: Rykoff model of the magnitude uncertainty (#526) * TST: assert photometric error is numerically close to the analytic value (#545) * TST: Drop deprecated astropy.tests.helper.raises (#546) * ENH: compute kcorrect remaining stellar mass (#476) * compute kcorrect remaining stellar mass * added test for stellar mass remain Co-authored-by: Ian Harrison <itrharrison@gmail.com> Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com> * ENH: Logistic completeness function (#521) * BLD: Set astropy latest supported version to 5.1 (#547) * BUG: `schechter_smf` callable input and docs (#525) * DOC: Typo in Rykoff error (#550) * add Fox's details (#551) Co-authored-by: Richard R <58728519+rrjbca@users.noreply.github.com> * BLD: Set numpy latest supported version to 1.23 (#552) * codestyle fixes * add six requirement for colossus * tried to fix docs builds * update passenv * rtd configuration Co-authored-by: Richard R <58728519+rrjbca@users.noreply.github.com> Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk> Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com> Co-authored-by: Sut-Ieng Tam <30295725+sutieng@users.noreply.github.com> Co-authored-by: philipp128 <48715661+philipp128@users.noreply.github.com> Co-authored-by: Fox Davidson <93545862+Fox-Davidson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

continuous integration documentation Improvements or additions to documentation infrastructure

2 participants