[C++]: address aeron-io#273 by adding virtual destructors to some interface classes. Add rt link for those Linuxes that need it. Add more STDC_LIMIT_MACROS sets to build.

Author: tmontgomery

CMakeLists.txt

@@ -16,6 +16,7 @@
 cmake_minimum_required(VERSION 2.8.5 FATAL_ERROR)
 
 include(ExternalProject)
+include(CheckLibraryExists)
 
 enable_testing()
 

examples/cpp98/SbeOtfDecoder.cpp

@@ -20,13 +20,14 @@
 #include <stdlib.h>
 #include <stdint.h>
 #else
+#define __STDC_LIMIT_MACROS 1
+#include <stdint.h>
 #include <sys/types.h>
 #include <sys/uio.h>
 #include <unistd.h>
 #include <sys/stat.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <stdint.h>
 #endif /* WIN32 */
 
 #include <iostream>

main/cpp/otf_api/Ir.cpp

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+#define __STDC_LIMIT_MACROS 1
+#include <stdint.h>
 #include <stdio.h>
 #include <iostream>
 #include <sys/types.h>

main/cpp/otf_api/Ir.h

@@ -16,6 +16,7 @@
 #ifndef _IR_H_
 #define _IR_H_
 
+#define __STDC_LIMIT_MACROS 1
 #include <stdint.h>
 #include <string.h>
 
@@ -143,6 +144,8 @@ class Ir
  * \return Ir for the message
  */
  virtual Ir *irForTemplateId(const int templateId, const int version) = 0;
+
+ virtual ~Callback() {}
  };
 
  // constructors and destructors

main/cpp/otf_api/Listener.h

@@ -17,6 +17,7 @@
 #ifndef _LISTENER_H_
 #define _LISTENER_H_
 
+#define __STDC_LIMIT_MACROS 1
 #include <stdint.h>
 #include <string.h>
 
@@ -115,6 +116,8 @@ class Listener
  return *this;
  }
 
+ virtual ~Listener() {}
+
  /**
  * \brief Reset state and initialize for decode of the given buffer.
  *

main/cpp/otf_api/OnCompleted.h

@@ -31,6 +31,8 @@ class OnCompleted
  * \return 0 for success and -1 for failure
  */
  virtual int onCompleted(void) = 0;
+
+ virtual ~OnCompleted() {}
 };
 
 } // namepsace on_the_fly

main/cpp/otf_api/OnError.h

@@ -52,6 +52,8 @@ class OnError
  * \sa Error
  */
  virtual int onError(const Error &error) = 0;
+
+ virtual ~OnError() {}
 };
 
 } // namepsace on_the_fly

main/cpp/otf_api/OnNext.h

@@ -45,6 +45,8 @@ class OnNext
  * \sa Group
  */
  virtual int onNext(const Group &group) = 0;
+
+ virtual ~OnNext() {}
 };
 
 } // namepsace on_the_fly

main/cpp/sbe/sbe.hpp

@@ -16,8 +16,8 @@
 #ifndef _SBE_HPP_
 #define _SBE_HPP_
 
+#define __STDC_LIMIT_MACROS 1
 #include <string.h>
-#define __STDC_LIMIT_MACROS
 #include <stdint.h>
 #include <limits.h>
 #include <stdexcept>

perf/cpp/CMakeLists.txt

@@ -17,6 +17,8 @@
 find_package(Java REQUIRED)
 find_package(Protobuf)
 
+CHECK_LIBRARY_EXISTS(rt clock_gettime "time.h" HAVE_CLOCK_GETTIME_RT)
+
 if(CMAKE_BUILD_TYPE STREQUAL "Release")
 message("Build type(${CMAKE_BUILD_TYPE}): perf tests turning OFF bounds checks")
 add_definitions(-DNDEBUG)
@@ -47,6 +49,11 @@ add_executable(benchlet-sbe-md-runner ${SRCS_BENCHLET_MAIN} MarketDataBench.cpp)
 add_dependencies(benchlet-sbe-md-runner perf_codecs)
 add_dependencies(benchlet-sbe-car-runner perf_codecs)
 
+if (HAVE_CLOCK_GETTIME_RT)
+ target_link_libraries(benchlet-sbe-md-runner rt)
+ target_link_libraries(benchlet-sbe-car-runner rt)
+endif (HAVE_CLOCK_GETTIME_RT)
+
 if(USE_PROTOBUF)
 set(PROTOBUF_CAR_SCHEMA ${CODEC_TARGET_DIR}/protobuf/car.proto)
 set(PROTOBUF_MD_SCHEMA ${CODEC_TARGET_DIR}/protobuf/fix-messages.proto)