Skip to content

Commit 6ccdda5

Browse files
committed
Merge remote-tracking branch 'refs/remotes/origin/feature/webpack-babel' into development
# Conflicts: # CONTRIBUTING.md # README.md # dist/schema-form.js # dist/schema-form.min.js # docs/index.md # gulp/tasks/minify.js # package.json # src/directives/field.js # src/directives/schema-form.js # src/directives/schema-validate.js # src/directives/sf-array.directive.js # src/directives/sf-schema.directive.spec.js # src/services/schema-form-decorators.provider.js # src/services/schema-form.js # src/services/sf-builder.provider.js
2 parents 79ba42f + cbf2379 commit 6ccdda5

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+7566
-3994
lines changed

.babelrc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"presets": [
3+
["es2015", { "modules": false }]
4+
]
5+
}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
node_modules
22
coverage
33
bower_components
4+
*.log

.jscs.json

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
{
22
"preset": "google",
3-
"maximumLineLength": 100,
4-
"disallowMultipleLineBreaks": false
3+
"disallowSpacesInsideObjectBrackets": null,
4+
"requireSpacesInsideObjectBrackets": {
5+
"allExcept": [ "[", "]", "{", "}" ]
6+
},
7+
"disallowSpacesInsideArrayBrackets": null,
8+
"requireSpacesInsideArrayBrackets": {
9+
"allExcept": [ "[", "]", "{", "}" ]
10+
},
11+
"disallowKeywordsOnNewLine": [ ],
12+
"disallowMultipleVarDecl": null,
13+
"maximumLineLength": 120,
14+
"requireSemicolons": true
515
}

.jshintrc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22
"undef": true,
33
"unused": true,
44
"browser": true,
5+
"esnext":true,
56
"globals": {
6-
"ObjectPath": false,
77
"console":false,
8-
"jQuery": false,
9-
"$":false,
108
"assertEquals": false,
119
"jstestdriver": false,
1210
"assertTrue": false,
@@ -17,7 +15,6 @@
1715
"sinon":false,
1816
"beforeEach": false,
1917
"afterEach": false,
20-
"angular": false,
2118
"module": false,
2219
"inject": false,
2320
"chai": false,

CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ We love contributions!
66

77
The reason for this is that we're trying to use
88
[git flow](http://danielkummer.github.io/git-flow-cheatsheet/), and it makes merging your pull
9-
request heck of a lot easier for us.
9+
request a heck of a lot easier for us.
1010

11-
Please avoid including anything from the `dist/` directory as that can make merging harder, and we
11+
Please **avoid including anything from the `dist/`** directory as that can make merging harder, and we
1212
always generate these files when we make a new release.
1313

14-
**We're currently in transitioning where a large part of the code, i.e. the bootstrap decorator, has been moved to it's own repo. It's here [github.com/Textalk/angular-schema-form-bootstrap](https://github.com/Textalk/angular-schema-form-bootstrap)**
14+
**The bootstrap decorator, has been moved to it's own repo. It's here [github.com/json-schema-form/angular-schema-form-bootstrap](https://github.com/json-schema-form/angular-schema-form-bootstrap)**
1515

1616
Feel free to submit issues on the main repo anyway though.
1717

@@ -22,5 +22,5 @@ With new features we love to see updates to the docs as well as tests, that make
2222
easy and fast for us to merge it!
2323

2424
Also consider running any code through the code style checker [jscs](https://github.com/mdevils/node-jscs)
25-
(or even better use it in your editor) with preset set to `google`. You can also use `gulp jscs` to
26-
check your code.
25+
(or even better use it in your editor) with preset set to `google`. You can also
26+
use `gulp jscs` to check your code. I hope to set up ESLint in the not too distant future.

README.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,30 @@ Angular Schema Form
99

1010
Generate forms from JSON schemas using AngularJS!
1111

12+
Branch Status & New Add-On
13+
--------------------------
14+
This branch will be the **next version of Angular Schema Form**, currently please use
15+
the **examples/example.html** file as the best example to get the framework working.
16+
17+
The example uses **schema-form.js** and **angular-schema-form-bootstrap.js** for the
18+
version of the code it executes, if you want your page to behave the same you
19+
obviously need the same version!
20+
21+
The new Webpack compilation has made it easier to manage files and code and run build
22+
scripts, but it is still not easy enough for users unfamiliar with it... yet.
23+
24+
**NOTE** in order to work simultaneously with ```json-schema-form-core``` you must have it cloned
25+
as a sibling directory to this one to build this library **OR** npm install the version you wish to build with.
26+
27+
Webpack now generates a header to indicate version and date of build. **Do not create PR with the DIST folder.**
28+
29+
### Add-on
30+
To see how to make an **add-on** work I have now included the **calculate** add-on file within the **examples/add-on** directory.
31+
32+
## Yet to be migrated
33+
Currently **copyValueTo** and some **array** related features are not working as expected and remain the highest priority to ensure backwards compatibility is maintained where possible.
34+
35+
1236
The Update
1337
==========
1438
Current development is occuring on the [feature/webpack-babel](https://github.com/json-schema-form/angular-schema-form/blob/feature/webpack-babel/README.md) branch. Once that is stable and passing all tests again it will be replace the current developer branch. Ideally any new PRs should target the new version to avoid migration issues.

bower.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
{
22
"name": "angular-schema-form",
3-
"main": [
4-
"dist/schema-form.js",
5-
"dist/bootstrap-decorator.js"
6-
],
3+
"main": "dist/schema-form.js",
74
"authors": [
85
"Textalk",
96
"David Jensen <david.lgj@gmail.com>",
@@ -41,8 +38,7 @@
4138
"dependencies": {
4239
"angular": ">= 1.2",
4340
"tv4": "~1.0.15",
44-
"angular-sanitize": ">= 1.2",
45-
"objectpath": "~1.1.0"
41+
"angular-sanitize": ">= 1.2"
4642
},
4743
"devDependencies": {
4844
"angular-ui-ace": "bower",
@@ -54,5 +50,8 @@
5450
"angular-ui-sortable": ">=0.12.11",
5551
"bootstrap-vertical-tabs": "~1.2.0",
5652
"angular-schema-form-bootstrap": "~0.1.1"
53+
},
54+
"resolutions": {
55+
"jquery": "~2.1.1"
5756
}
5857
}

0 commit comments

Comments
 (0)