Skip to content

Conversation

@wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Apr 26, 2024

This PR is a debug/fix of #2496, preserving all its commits.

Testing locally:

seq 1000 | xargs -I {} sh -c 'FILTER=test-multi-result-streaming npm run test || echo "Failure at iteration {}" >> failures.log'
  • I ran all the CI 3 times, just to make sure.
@codecov
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (9edfd72) to head (f98476d).
Report is 28 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #2628 +/- ## ======================================= Coverage 90.32% 90.32% ======================================= Files 71 71 Lines 15727 15727 Branches 1339 1339 ======================================= Hits 14206 14206 Misses 1521 1521 
Flag Coverage Δ
compression-0 90.32% <100.00%> (ø)
compression-1 90.32% <100.00%> (ø)
tls-0 89.85% <100.00%> (ø)
tls-1 90.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel changed the title debug: PR #2496 fix(stream): reads should emit the dataset number for each dataset Apr 26, 2024
@wellwelwel wellwelwel marked this pull request as ready for review April 26, 2024 20:43
@wellwelwel wellwelwel added the mysqljs/mysql incompatibilities Previously: feligxe-mysql-incompatibilities label Apr 27, 2024
@wellwelwel wellwelwel closed this May 6, 2024
@wellwelwel wellwelwel deleted the stream branch May 6, 2024 20:45
@wellwelwel wellwelwel restored the stream branch May 6, 2024 20:45
@wellwelwel wellwelwel reopened this May 6, 2024
@wellwelwel wellwelwel merged commit 4dab4ca into sidorares:master May 30, 2024
@wellwelwel wellwelwel deleted the stream branch May 30, 2024 19:00
Vylpes pushed a commit to Vylpes/Droplet that referenced this pull request Jun 3, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [mysql2](https://sidorares.github.io/node-mysql2/docs) ([source](https://github.com/sidorares/node-mysql2)) | dependencies | minor | [`3.9.8` -> `3.10.0`](https://renovatebot.com/diffs/npm/mysql2/3.9.8/3.10.0) | --- ### Release Notes <details> <summary>sidorares/node-mysql2 (mysql2)</summary> ### [`v3.10.0`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#3100-2024-05-30) [Compare Source](sidorares/node-mysql2@v3.9.9...v3.10.0) ##### Features - add jsonStrings option ([#&#8203;2642](sidorares/node-mysql2#2642)) ([9820fe5](sidorares/node-mysql2@9820fe5)) ##### Bug Fixes - **stream:** reads should emit the dataset number for each dataset ([#&#8203;2628](sidorares/node-mysql2#2628)) ([4dab4ca](sidorares/node-mysql2@4dab4ca)) ### [`v3.9.9`](https://github.com/sidorares/node-mysql2/blob/HEAD/Changelog.md#399-2024-05-29) [Compare Source](sidorares/node-mysql2@v3.9.8...v3.9.9) ##### Bug Fixes - **connection config:** remove keepAliveInitialDelay default value ([#&#8203;2712](sidorares/node-mysql2#2712)) ([688ebab](sidorares/node-mysql2@688ebab)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/Droplet/pulls/314 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mysqljs/mysql incompatibilities Previously: feligxe-mysql-incompatibilities

2 participants