Merge pull request #1942 from shirou/fix/linter_error

fix: linter error about string concat and build tag

Author: shirou

host/host_aix_ppc64.go

@@ -1,5 +1,4 @@
 //go:build aix && ppc64 && cgo
-// +build aix,ppc64,cgo
 
 // Guessed at from the following document:
 // https://www.ibm.com/docs/sl/ibm-mq/9.2?topic=platforms-standard-data-types-aix-linux-windows

internal/common/warnings.go

@@ -1,7 +1,10 @@
 // SPDX-License-Identifier: BSD-3-Clause
 package common
 
-import "fmt"
+import (
+"fmt"
+"strings"
+)
 
 const (
 maxWarnings = 100 // An arbitrary limit to avoid excessive memory usage, it has no sense to store hundreds of errors
@@ -33,9 +36,11 @@ func (w *Warnings) Reference() error {
 func (w *Warnings) Error() string {
 if w.Verbose {
 str := ""
+var sb strings.Builder
 for i, e := range w.List {
-str += fmt.Sprintf("\tError %d: %s\n", i, e.Error())
+sb.WriteString(fmt.Sprintf("\tError %d: %s\n", i, e.Error()))
 }
+str += sb.String()
 if w.tooManyErrors {
 str += fmt.Sprintf("\t%s\n", tooManyErrorsMessage)
 }

net/net_linux.go

@@ -50,26 +50,25 @@ func IOCountersByFileWithContext(_ context.Context, pernic bool, filename string
 return nil, err
 }
 
-parts := make([]string, 2)
-
 statlen := len(lines) - 1
 
 ret := make([]IOCountersStat, 0, statlen)
 
 for _, line := range lines[2:] {
+// Split interface name and stats data at the last ":"
 separatorPos := strings.LastIndex(line, ":")
 if separatorPos == -1 {
 continue
 }
-parts[0] = line[0:separatorPos]
-parts[1] = line[separatorPos+1:]
+interfacePart := line[0:separatorPos]
+statsPart := line[separatorPos+1:]
 
-interfaceName := strings.TrimSpace(parts[0])
+interfaceName := strings.TrimSpace(interfacePart)
 if interfaceName == "" {
 continue
 }
 
-fields := strings.Fields(strings.TrimSpace(parts[1]))
+fields := strings.Fields(strings.TrimSpace(statsPart))
 bytesRecv, err := strconv.ParseUint(fields[0], 10, 64)
 if err != nil {
 return ret, err