Skip to content

Commit 82b4413

Browse files
committed
Remove old Procfile, Update Readme, gitignore and rescript files
1 parent 1debe86 commit 82b4413

File tree

10 files changed

+12
-24
lines changed

10 files changed

+12
-24
lines changed

.gitignore

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,3 @@ lib/bs/
3030
.merlin
3131
.bsb.lock
3232
*.bs.js
33-
34-
/public/packs
35-
/public/packs-test
36-
/node_modules
37-
/yarn-error.log
38-
yarn-debug.log*
39-
.yarn-integrity

Procfile.dev-server

Lines changed: 0 additions & 6 deletions
This file was deleted.

Procfile.dev-static

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# You can run these commands in separate shells
2+
rescript: yarn start
3+
24
web: rails s -p 3000
35

46
# Next line runs a watch process with webpack to compile the changed files.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# reason-react-on-rails-example
1+
# rescript-react-on-rails-example
22

33
## Setup the app
44
```
@@ -10,16 +10,16 @@
1010
## Run the app
1111

1212
```
13-
foreman start -f Procfile.dev
13+
foreman start -f Procfile.dev-static
1414
```
1515

1616
or
1717

1818
```
19-
foreman start -f Procfile.dev-server
19+
foreman start -f Procfile.dev
2020
```
2121

22-
The latter will automatically reload the brower window when the you save a change to the `.re` file.
22+
The latter will automatically reload the browser window when the you save a change to the `.res` file.
2323

2424
# Docker Instructions
2525

app/javascript/Utils.res

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
let eventTargetValue = event => {
22
let target = event -> ReactEvent.Form.target
3-
// ReactDOM.domElementToObj(target)["value"]
43
target["value"]
5-
}
4+
}

app/javascript/bundles/HelloWorld/HelloWorld.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ let make = (~nameProp: string) => {
1111
/>
1212
</form>
1313
</div>
14-
}
14+
}

app/javascript/packs/HelloWorldBundle.res

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ type context = {
1717

1818
let component = (props: props, _context: context) => <HelloWorld nameProp={props["name"]} />
1919

20-
ReactOnRails.register("HelloWorld", component)
20+
ReactOnRails.register("HelloWorld", component)
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
import './HelloWorldBundle.bs.js';
1+
import './HelloWorldBundle.bs.js';

bin/webpack

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env ruby
22

3-
ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
3+
ENV["RAILS_ENV"] ||= "development"
44
ENV["NODE_ENV"] ||= "development"
55

66
require "pathname"

bin/webpack-dev-server

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env ruby
22

3-
ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
3+
ENV["RAILS_ENV"] ||= "development"
44
ENV["NODE_ENV"] ||= "development"
55

66
require "pathname"

0 commit comments

Comments
 (0)