updates for readability #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Also, add comment to database.yml
| @robwise Check this out. |
There was a problem hiding this comment.
Why are we using group blocks for some gems (see line 55, for example) and passing them as hash options for others?
There was a problem hiding this comment.
I think maybe no reasons for this, but sometimes the order of loading gems matter.
There was a problem hiding this comment.
Whatever makes sense for readability. Usually the DB gems go at the top.
There was a problem hiding this comment.
Totally agree with @justin808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Also, add comment to database.yml