Update application.js #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Just as a note: we determined the shim in application.js was not necessary because the shim is already being included in the webpack, so we don't need to also include it in sprockets. |
robwise force-pushed the justin808-remove-es5shim-applicationjs branch from f489f11 to 48218b3 Compare robwise added a commit that referenced this pull request Oct 29, 2015
…cationjs Drop es5-shim from application.js since it's already being loaded in Webpack
| Based on this merge, would it be ok to remove gem 'es5-shim-rails' from Gemfile? |
| Thx for the quick response @robwise |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.