Skip to content

Commit 5a78565

Browse files
committed
Misc fixes related to updates for the bootstrap-sass-loader
1 parent 86e14cf commit 5a78565

File tree

11 files changed

+835
-534
lines changed

11 files changed

+835
-534
lines changed

.gitignore

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
/log/*.log
1616
/tmp
1717
/public/assets
18-
rails-bundle.js
19-
rails-bundle.js.map
18+
webpack-bundle.js
19+
webpack-bundle.js.map
2020
.env
2121
/node_modules
2222
npm-debug.log

Procfile.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
web: rails s -p 4000
2-
webpack: cd webpack && $(npm bin)/webpack -w --config webpack.bundle.config.js
2+
webpack: cd webpack && $(npm bin)/webpack -w --config webpack.rails.config.js

app/assets/images/.keep

Whitespace-only changes.

app/assets/stylesheets/_bootstrap-custom.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,6 @@
5454
// Utility classes
5555
@import "bootstrap/utilities";
5656
@import "bootstrap/responsive-utilities";
57+
58+
// This must come after all the boostrap styles are loaded so that these styles can override those.
59+
@import "app-styling-post-bootstrap-loading";
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1+
// This variable $rails is used by bootstrap-custom so that fonts are loaded slightly differently
2+
// with Rails vs. the Webpack Dev Server
13
$rails: true;
24

35
// Those scss files are located under webpack/assets/stylesheets,
46
// which has been added to the Rails asset pipeline search path.
57
// See config/application.rb.
8+
@import "bootstrap-custom";
69
@import "test-stylesheet";
710
@import "test-sass-stylesheet";
811

912
@import "bootstrap-sprockets";
10-
@import "bootstrap-custom";
11-
12-
@import "pages"; // a custom font is defined there

app/assets/stylesheets/pages.css.scss

Lines changed: 0 additions & 12 deletions
This file was deleted.

npm-shrinkwrap.json

Lines changed: 808 additions & 509 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
"node": "0.10.32"
88
},
99
"dependencies": {
10-
"bootstrap-sass": "~3.3.1",
11-
"bootstrap-sass-loader": "~0.0.4",
12-
"imports-loader": "^0.6.3",
1310
"body-parser": "^1.9.0",
11+
"bootstrap-sass": "^3.3.1",
12+
"bootstrap-sass-loader": "0.0.5",
1413
"bootstrap-webpack": "*",
1514
"es6-loader": "^0.2.0",
1615
"express": "^4.9.8",
16+
"imports-loader": "^0.6.3",
1717
"jquery": "^2.1.1",
1818
"jsx-loader": "^0.11.2",
1919
"loader-utils": "^0.2.2",

webpack/assets/javascripts/example.jsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,14 @@ var render = () => {
1010
React.renderComponent(
1111
<div>
1212
<CommentBox url="comments.json" pollInterval={2000} />
13-
<div className="logo container">Brought to you by</div>
13+
<div className="container">
14+
<a href="http://www.railsonmaui.com">
15+
<h3 className="open-sans-light">
16+
<div className="logo"/>
17+
Example of styling using image-url and Open Sans Light custom font
18+
</h3>
19+
</a>
20+
</div>
1421
</div>,
1522
document.getElementById('content')
1623
);

webpack/_main.scss renamed to webpack/assets/stylesheets/_app-styling-post-bootstrap-loading.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,12 @@ body {
1818
background-image: image-url("railsonmaui.png");
1919
background-repeat: no-repeat;
2020
background-position: left bottom;
21-
height: 60px;
22-
padding: 0;
21+
height: 40px;
22+
width: 146px;
23+
margin-right: 10px;
24+
display: inline-block;
25+
}
26+
.open-sans-light {
2327
font-family: 'OpenSans-Light'; // making use of custom fonts
2428
}
2529

0 commit comments

Comments
 (0)