Detect yarn version to dynamically not add deprecated flags #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jagonzalr force-pushed the detect-yarn-2-or-above branch from 983c2d2 to 8d76b02 Compare 
vicary reviewed Oct 13, 2022
Member
vicary left a comment
vicary left a comment There was a problem hiding this comment.
Allow my nitpicking. Just a rename and we're good to go!
jagonzalr force-pushed the detect-yarn-2-or-above branch from b947ab1 to 1582a2e Compare 
jagonzalr force-pushed the detect-yarn-2-or-above branch from 1582a2e to eb892ec Compare 
Contributor Author
j0k3r approved these changes Oct 14, 2022
Member
| Good job @jagonzalr 👏🏼 |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #642
How did you implement it:
This is an upgrade to a previous PR of mine.
The package can now detect the
Yarnversion to dynamically use the flags--frozen-lockfileor--immutabledepending if running v1.x (classic) or v.2x, v3.x (modern).If will also dynamically avoid injecting the flag
--non-interactiveeven if you don't disable it on theserverless.ymlfile.How can we verify it:
npm run testTodos:
Is this ready for review?: YES
Is it a breaking change?: NO