Minor README update #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed typos, etc.
dimitryzub reviewed Jul 25, 2022
Contributor
There was a problem hiding this comment.
@ajsierra117 Thank you for finding and fixing typos as well as for fixing this code prints Google Scholar search results where Google Scholar was the wrong API name that was repeated 4 times instead of 1🙂
Everything looks good to me 👍 @kagermanov27 if you have time, what do you think about @ajsierra117 suggestions and suggestions below?
Not related to this PR. Curious what you think.
I'm also thinking about changing text placement where code snippet appears, for example:
I think it will get more sense to have the text before the code snippet rather than after in order to avoid confusion that the text after "first" code snippet is text for the "second" code snippet, for example:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed typos, etc.