Skip to content

Commit 31e24a7

Browse files
Merge pull request #456 from jamesldr/master
fix: Rename CarouselController to CarouselSliderController
2 parents 36d3f39 + becf7ba commit 31e24a7

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@ CarouselSlider.builder(
100100

101101
## Carousel controller
102102

103-
In order to manually control the pageview's position, you can create your own `CarouselController`, and pass it to `CarouselSlider`. Then you can use the `CarouselController` instance to manipulate the position.
103+
In order to manually control the pageview's position, you can create your own `CarouselSliderController`, and pass it to `CarouselSlider`. Then you can use the `CarouselSliderController` instance to manipulate the position.
104104

105105
```dart
106106
class CarouselDemo extends StatelessWidget {
107-
CarouselController buttonCarouselController = CarouselController();
107+
CarouselSliderController buttonCarouselController = CarouselSliderController();
108108
109109
@override
110110
Widget build(BuildContext context) => Column(
@@ -130,7 +130,7 @@ class CarouselDemo extends StatelessWidget {
130130
}
131131
```
132132

133-
### `CarouselController` methods
133+
### `CarouselSliderController` methods
134134

135135
#### `.nextPage({Duration duration, Curve curve})`
136136

@@ -170,7 +170,7 @@ Image carousel slider with custom indicator demo:
170170

171171
![indicator](screenshot/indicator.gif)
172172

173-
Custom `CarouselController` and manually control the pageview position demo:
173+
Custom `CarouselSliderController` and manually control the pageview position demo:
174174

175175
![manual](screenshot/manually.gif)
176176

example/lib/main.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ class ManuallyControlledSlider extends StatefulWidget {
255255
}
256256

257257
class _ManuallyControlledSliderState extends State<ManuallyControlledSlider> {
258-
final CarouselController _controller = CarouselController();
258+
final CarouselSliderController _controller = CarouselSliderController();
259259

260260
@override
261261
void initState() {
@@ -408,7 +408,7 @@ class CarouselWithIndicatorDemo extends StatefulWidget {
408408

409409
class _CarouselWithIndicatorState extends State<CarouselWithIndicatorDemo> {
410410
int _current = 0;
411-
final CarouselController _controller = CarouselController();
411+
final CarouselSliderController _controller = CarouselSliderController();
412412

413413
@override
414414
Widget build(BuildContext context) {
@@ -515,7 +515,7 @@ class CarouselChangeReasonDemo extends StatefulWidget {
515515

516516
class _CarouselChangeReasonDemoState extends State<CarouselChangeReasonDemo> {
517517
String reason = '';
518-
final CarouselController _controller = CarouselController();
518+
final CarouselSliderController _controller = CarouselSliderController();
519519

520520
void onPageChange(int index, CarouselPageChangedReason changeReason) {
521521
setState(() {

lib/carousel_controller.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'carousel_options.dart';
66
import 'carousel_state.dart';
77
import 'utils.dart';
88

9-
abstract class CarouselController {
9+
abstract class CarouselSliderController {
1010
bool get ready;
1111

1212
Future<Null> get onReady;
@@ -23,10 +23,10 @@ abstract class CarouselController {
2323

2424
void stopAutoPlay();
2525

26-
factory CarouselController() => CarouselControllerImpl();
26+
factory CarouselSliderController() => CarouselSliderControllerImpl();
2727
}
2828

29-
class CarouselControllerImpl implements CarouselController {
29+
class CarouselSliderControllerImpl implements CarouselSliderController {
3030
final Completer<Null> _readyCompleter = Completer<Null>();
3131

3232
CarouselState? _state;

lib/carousel_slider.dart

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,21 +31,21 @@ class CarouselSlider extends StatefulWidget {
3131
final ExtendedIndexedWidgetBuilder? itemBuilder;
3232

3333
/// A [MapController], used to control the map.
34-
final CarouselControllerImpl _carouselController;
34+
final CarouselSliderControllerImpl _carouselController;
3535

3636
final int? itemCount;
3737

3838
CarouselSlider(
3939
{required this.items,
4040
required this.options,
4141
this.disableGesture,
42-
CarouselController? carouselController,
42+
CarouselSliderController? carouselController,
4343
Key? key})
4444
: itemBuilder = null,
4545
itemCount = items != null ? items.length : 0,
4646
_carouselController = carouselController != null
47-
? carouselController as CarouselControllerImpl
48-
: CarouselController() as CarouselControllerImpl,
47+
? carouselController as CarouselSliderControllerImpl
48+
: CarouselSliderController() as CarouselSliderControllerImpl,
4949
super(key: key);
5050

5151
/// The on demand item builder constructor
@@ -54,12 +54,12 @@ class CarouselSlider extends StatefulWidget {
5454
required this.itemBuilder,
5555
required this.options,
5656
this.disableGesture,
57-
CarouselController? carouselController,
57+
CarouselSliderController? carouselController,
5858
Key? key})
5959
: items = null,
6060
_carouselController = carouselController != null
61-
? carouselController as CarouselControllerImpl
62-
: CarouselController() as CarouselControllerImpl,
61+
? carouselController as CarouselSliderControllerImpl
62+
: CarouselSliderController() as CarouselSliderControllerImpl,
6363
super(key: key);
6464

6565
@override
@@ -68,7 +68,7 @@ class CarouselSlider extends StatefulWidget {
6868

6969
class CarouselSliderState extends State<CarouselSlider>
7070
with TickerProviderStateMixin {
71-
final CarouselControllerImpl carouselController;
71+
final CarouselSliderControllerImpl carouselController;
7272
Timer? timer;
7373

7474
CarouselOptions get options => widget.options;
@@ -355,7 +355,7 @@ class CarouselSliderState extends State<CarouselSlider>
355355
BuildContext storageContext = carouselState!
356356
.pageController!.position.context.storageContext;
357357
final double? previousSavedPosition =
358-
PageStorage.of(storageContext)?.readState(storageContext)
358+
PageStorage.of(storageContext).readState(storageContext)
359359
as double?;
360360
if (previousSavedPosition != null) {
361361
itemOffset = previousSavedPosition - idx.toDouble();

0 commit comments

Comments
 (0)