add missing keys to cached translations

Author: vsch

src/Manager.php

@@ -276,10 +276,11 @@ function firstOrNewTranslation($attributes = null)
  && array_key_exists('locale', $attributes) && array_key_exists('key', $attributes)
  && array_key_exists($attributes['locale'], $this->preloadedGroupLocales)
  ) {
+ $checkDB = false;
+ 
  if (array_key_exists($attributes['key'], $this->preloadedGroupKeys)
  && array_key_exists($attributes['locale'], $this->preloadedGroupKeys[$attributes['key']])
  ) {
- $checkDB = false;
  $translation = $this->preloadedGroupKeys[$attributes['key']][$attributes['locale']];
  }
  }
@@ -298,6 +299,9 @@ function firstOrNewTranslation($attributes = null)
  $translation = new Translation();
  $translation->fill($attributes);
  $translation->setConnection($this->getConnectionName());
+
+ // put it in the cache as empty so we don't hit the database every time
+ $this->cacheTranslation('', $translation->group, $translation->key, null, $translation->locale);
  }
 
  return $translation;
@@ -308,6 +312,9 @@ function firstOrCreateTranslation($attributes = null)
  $translation = $this->firstOrNewTranslation($attributes);
  if (!$translation->exists) {
  $translation->save();
+
+ // put it in the cache as empty so we don't hit the database every time
+ $this->cacheTranslation('', $translation->group, $translation->key, null, $translation->locale);
  }
 
  return $translation;

versioninfo.md

@@ -7,6 +7,8 @@ The 1.x.x versions are for Laravel 4.2, 2.1.x versions are for Laravel 5.1+, 2.3
 
 * Fix: unpublished mode shows groups not in LTM database as undefined. 
 * Fix: unpublished mode showing translations marked deleted instead of as undefined
+* Fix: add missing keys to the cache to not thrash the database on every access to their
+ translations
 
 #### 2.6.28