Skip to content

Commit 40fdb0a

Browse files
committed
refactoring
1 parent cbec2f4 commit 40fdb0a

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

script-engine-tansformer/src/main/java/seko/kafka/connect/transformer/python/ScriptEngineTransformer.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@
1313
import javax.script.ScriptEngine;
1414
import javax.script.ScriptEngineManager;
1515
import javax.script.ScriptException;
16-
import java.util.*;
16+
import java.util.ArrayList;
17+
import java.util.List;
18+
import java.util.Map;
19+
import java.util.Optional;
1720

1821
import static org.apache.kafka.common.config.ConfigDef.Importance.MEDIUM;
1922
import static org.apache.kafka.common.config.ConfigDef.NO_DEFAULT_VALUE;
@@ -117,7 +120,7 @@ public void configure(Map<String, ?> configs) {
117120

118121
private ScriptEngine getScript(String script) {
119122
ScriptEngine scriptEngine;
120-
if (Arrays.asList("nashorn", "javascript").contains(getScripEngineName().toLowerCase())) {
123+
if (JS_SCRIPT_ENGINE_NAMES.contains(getScripEngineName().toLowerCase())) {
121124
scriptEngine = new NashornScriptEngineFactory().getScriptEngine("-strict", "--no-java", "--no-syntax-extensions");
122125
} else {
123126
scriptEngine = new ScriptEngineManager().getEngineByName(getScripEngineName());

shared/src/main/java/seko/kafka/connect/transformer/script/configs/Configuration.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package seko.kafka.connect.transformer.script.configs;
22

3+
import java.util.Arrays;
4+
import java.util.List;
5+
36
public final class Configuration {
47
public static final String SCRIP_ENGINE_NAME = "scrip_engine_name";
58

@@ -8,6 +11,8 @@ public final class Configuration {
811
public static final String FIELD_FOR_EXCEPTION = "field_for_exception";
912
public static final String FIELD_FOR_EXCEPTION_DEFAULT = "script_engine_transformer_tags";
1013

14+
public static final List<String> JS_SCRIPT_ENGINE_NAMES = Arrays.asList("nashorn", "javascript");
15+
1116
private Configuration() {
1217
}
1318
}

0 commit comments

Comments
 (0)