Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Commit 4264009

Browse files
committed
Rename CloseAllArgs to Close
1 parent 3a5d506 commit 4264009

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

conn_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,5 +148,5 @@ func TestConnMulti(t *testing.T) {
148148
t.Error("second response:", err)
149149
return
150150
}
151-
res2.CloseAllArgs()
151+
res2.Close()
152152
}

pool.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ func dialLoop(txch <-chan connTx, config poolConfig) {
7979
go func(tx connTx) {
8080
defer cancel()
8181
if r, err := tx.recv(); err == nil {
82-
//r.Args.Close()
83-
r.CloseAllArgs()
82+
r.Close()
8483
}
8584
}(tx)
8685
}

response.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func (res *Response) Write(w io.Writer) error {
3838
return enc.Close()
3939
}
4040

41-
func (res *Response) CloseAllArgs() error {
41+
func (res *Response) Close() error {
4242
for _, arg := range res.Args {
4343
if err := arg.Close(); err != nil {
4444
return err

transport_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func TestTransport(t *testing.T) {
2121
); err != nil {
2222
t.Error(err)
2323
} else {
24-
res.CloseAllArgs()
24+
res.Close()
2525
}
2626

2727
transport.CloseIdleConnections()
@@ -52,7 +52,7 @@ func TestTransport(t *testing.T) {
5252
return
5353
}
5454

55-
if err = res.CloseAllArgs(); err != nil {
55+
if err = res.Close(); err != nil {
5656
t.Error(err)
5757
return
5858
}
@@ -74,7 +74,7 @@ func TestTransport(t *testing.T) {
7474
}
7575
}
7676

77-
if err = res.CloseAllArgs(); err != nil {
77+
if err = res.Close(); err != nil {
7878
t.Error(err)
7979
return
8080
}
@@ -102,7 +102,7 @@ func TestTransport(t *testing.T) {
102102
); err != nil {
103103
t.Error(err)
104104
} else {
105-
res.CloseAllArgs()
105+
res.Close()
106106
}
107107

108108
// Wait a bunch so the transport's internal goroutines will cleanup the

0 commit comments

Comments
 (0)