Cleanup process handling after dropping temp-file handling

Author: staabm

src/Util/PHP/AbstractPhpProcess.php

@@ -53,10 +53,6 @@ abstract class AbstractPhpProcess
 
  public static function factory(): self
  {
- if (PHP_OS_FAMILY === 'Windows') {
- return new WindowsPhpProcess;
- }
-
  return new DefaultPhpProcess;
  }
 

src/Util/PHP/DefaultPhpProcess.php

@@ -40,7 +40,7 @@ class DefaultPhpProcess extends AbstractPhpProcess
  */
  public function runJob(string $job, array $settings = []): array
  {
- if ($this->stdin || $this->useTemporaryFile()) {
+ if ($this->stdin) {
  if (!($this->tempFile = tempnam(sys_get_temp_dir(), 'phpunit_')) ||
  file_put_contents($this->tempFile, $job) === false) {
  throw new PhpProcessException(
@@ -143,9 +143,4 @@ protected function cleanup(): void
  unlink($this->tempFile);
  }
  }
-
- protected function useTemporaryFile(): bool
- {
- return false;
- }
 }