fix(isdatebefore): update date comparison logic

Author: eweseong

src/isDateBefore/isDateBefore.test.ts

@@ -28,8 +28,8 @@ describe("Util: isDateBefore", () => {
  },
  {
  statement: "Should return false if date1 is not before date2",
- date1: new Date("2020-12-28"),
- date2: new Date("2020-12-25"),
+ date1: new Date("2023-03-04"),
+ date2: new Date("2023-02-15"),
  result: false,
  },
  {

src/isDateBefore/isDateBefore.ts

@@ -7,13 +7,9 @@ import { isValidDate } from "../isValidDate";
  * @returns {boolean} True if date `a` comes before date `b`
  */
 export function isDateBefore(a: Date, b: Date): boolean {
- if (!isValidDate(a) || !isValidDate(b)) {
- return a < b;
- } else {
- return (
- a.getFullYear() < b.getFullYear() ||
- a.getMonth() < b.getMonth() ||
- a.getDate() < b.getDate()
- );
+ if (isValidDate(a) && isValidDate(b)) {
+ return a.setHours(0, 0, 0).valueOf() < b.setHours(0, 0, 0).valueOf();
  }
+
+ return a < b;
 }