Skip to content

Test improvement #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Test improvement #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ composer.phar
phpunit.xml
vendor/
build/
.phpunit.result.cache
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ jobs:
fast_finish: true

before_script:
- composer install --dev --prefer-source
- composer install --prefer-source

script: ./vendor/bin/phpunit --coverage-text
script: ./vendor/bin/phpunit --coverage-text
4 changes: 2 additions & 2 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<phpunit bootstrap="vendor/autoload.php"
colors="true">
<testsuites>
<testsuite>
<testsuite name="php-dom-wrapper testsuite">
<directory>tests</directory>
</testsuite>
</testsuites>
Expand All @@ -20,4 +20,4 @@
<directory suffix=".php">src</directory>
</whitelist>
</filter>
</phpunit>
</phpunit>
6 changes: 3 additions & 3 deletions tests/Node/DocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function testDocumentSetHtmlEncoding() {
public function testDocumentParent() {
$doc = $this->document('<html></html>');

$this->assertSame(null, $doc->parent());
$this->assertNull($doc->parent());
}

public function testDocumentParents() {
Expand All @@ -35,6 +35,6 @@ public function testDocumentClone() {
$doc = $this->document('<html></html>');
$clone = $doc->_clone();

$this->assertSame(null, $clone);
$this->assertNull($clone);
}
}
}
6 changes: 3 additions & 3 deletions tests/Traversal/EqTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function testEq() {
$this->assertInstanceOf('\DOMNode', $nodes->eq(3));
$this->assertSame('div', $nodes->eq(3)->nodeName);

$this->assertSame(null, $nodes->eq(4));
$this->assertNull($nodes->eq(4));

$this->assertInstanceOf('\DOMNode', $nodes->eq(-1));
$this->assertSame('div', $nodes->eq(-1)->nodeName);
Expand All @@ -41,6 +41,6 @@ public function testEq() {
$this->assertSame('div', $nodes->eq(-4)->nodeName);
$this->assertSame('example', $nodes->eq(-4)->attr('class'));

$this->assertSame(null, $nodes->eq(-5));
$this->assertNull($nodes->eq(-5));
}
}
}