Skip to content

Test improvement #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2020
Merged

Test improvement #28

merged 1 commit into from
Mar 17, 2020

Conversation

@peter279k
Copy link
Contributor

@peter279k peter279k commented Feb 29, 2020

Changed log

  • Using the assertNull to determine expected type is null.
  • Let the .phpunit.result.cache not be under Git version control because it's generated by phpunit.
  • The testsuite tag needs the name attribute on phpunit.xml.dist file.
    The warning message is as follows:
PHPUnit 8.5.2 by Sebastian Bergmann and contributors. Warning - The configuration file did not pass validation! The following problems have been detected: Line 5: - Element 'testsuite': The attribute 'name' is required but missing. Test results may not be as expected.
  • Removing --dev option on composer install command, and the deprecated warning message is as follows:
You are using the deprecated option "dev". Dev packages are installed by default now.
@scotteh scotteh merged commit a6c1c98 into scotteh:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@peter279k @scotteh