MAINT remove possibility to pass arguments by position (#952)

Author: glemaitre

imblearn/base.py

@@ -12,7 +12,7 @@
 from sklearn.utils.multiclass import check_classification_targets
 
 from .utils import check_sampling_strategy, check_target_type
-from .utils._validation import ArraysTransformer, _deprecate_positional_args
+from .utils._validation import ArraysTransformer
 
 
 class SamplerMixin(BaseEstimator, metaclass=ABCMeta):
@@ -241,7 +241,6 @@ class FunctionSampler(BaseSampler):
 
  _sampling_type = "bypass"
 
- @_deprecate_positional_args
  def __init__(self, *, func=None, accept_sparse=True, kw_args=None, validate=True):
  super().__init__()
  self.func = func

imblearn/combine/_smote_enn.py

@@ -13,7 +13,6 @@
 from ..under_sampling import EditedNearestNeighbours
 from ..utils import Substitution, check_target_type
 from ..utils._docstring import _n_jobs_docstring, _random_state_docstring
-from ..utils._validation import _deprecate_positional_args
 
 
 @Substitution(
@@ -103,7 +102,6 @@ class SMOTEENN(BaseSampler):
 
  _sampling_type = "over-sampling"
 
- @_deprecate_positional_args
  def __init__(
  self,
  *,

imblearn/combine/_smote_tomek.py

@@ -14,7 +14,6 @@
 from ..under_sampling import TomekLinks
 from ..utils import Substitution, check_target_type
 from ..utils._docstring import _n_jobs_docstring, _random_state_docstring
-from ..utils._validation import _deprecate_positional_args
 
 
 @Substitution(
@@ -101,7 +100,6 @@ class SMOTETomek(BaseSampler):
 
  _sampling_type = "over-sampling"
 
- @_deprecate_positional_args
  def __init__(
  self,
  *,

imblearn/datasets/_imbalance.py

@@ -9,10 +9,8 @@
 
 from ..under_sampling import RandomUnderSampler
 from ..utils import check_sampling_strategy
-from ..utils._validation import _deprecate_positional_args
 
 
-@_deprecate_positional_args
 def make_imbalance(
  X, y, *, sampling_strategy=None, random_state=None, verbose=False, **kwargs
 ):

imblearn/datasets/_zenodo.py

@@ -54,8 +54,6 @@
 from sklearn.datasets import get_data_home
 from sklearn.utils import Bunch, check_random_state
 
-from ..utils._validation import _deprecate_positional_args
-
 URL = "https://zenodo.org/record/61452/files/benchmark-imbalanced-learn.tar.gz"
 PRE_FILENAME = "x"
 POST_FILENAME = "data.npz"
@@ -97,7 +95,6 @@
  MAP_ID_NAME[v + 1] = k
 
 
-@_deprecate_positional_args
 def fetch_datasets(
  *,
  data_home=None,

imblearn/ensemble/_bagging.py

@@ -24,7 +24,6 @@
 from ..utils import Substitution, check_sampling_strategy, check_target_type
 from ..utils._available_if import available_if
 from ..utils._docstring import _n_jobs_docstring, _random_state_docstring
-from ..utils._validation import _deprecate_positional_args
 from ._common import _estimator_has
 
 
@@ -253,7 +252,6 @@ class BalancedBaggingClassifier(BaggingClassifier):
  [ 2 225]]
  """
 
- @_deprecate_positional_args
  def __init__(
  self,
  estimator=None,

imblearn/ensemble/_easy_ensemble.py

@@ -23,7 +23,6 @@
 from ..utils import Substitution, check_sampling_strategy, check_target_type
 from ..utils._available_if import available_if
 from ..utils._docstring import _n_jobs_docstring, _random_state_docstring
-from ..utils._validation import _deprecate_positional_args
 from ._common import _estimator_has
 
 MAX_INT = np.iinfo(np.int32).max
@@ -178,7 +177,6 @@ class EasyEnsembleClassifier(BaggingClassifier):
  [ 2 225]]
  """
 
- @_deprecate_positional_args
  def __init__(
  self,
  n_estimators=10,

imblearn/ensemble/_forest.py

@@ -33,7 +33,7 @@
 from ..under_sampling.base import BaseUnderSampler
 from ..utils import Substitution
 from ..utils._docstring import _n_jobs_docstring, _random_state_docstring
-from ..utils._validation import _deprecate_positional_args, check_sampling_strategy
+from ..utils._validation import check_sampling_strategy
 
 MAX_INT = np.iinfo(np.int32).max
 sklearn_version = parse_version(sklearn.__version__)
@@ -352,7 +352,6 @@ class labels (multi-output problem).
  [1]
  """
 
- @_deprecate_positional_args
  def __init__(
  self,
  n_estimators=100,

imblearn/ensemble/_weight_boosting.py

@@ -16,7 +16,6 @@
 from ..under_sampling.base import BaseUnderSampler
 from ..utils import Substitution, check_target_type
 from ..utils._docstring import _random_state_docstring
-from ..utils._validation import _deprecate_positional_args
 
 
 @Substitution(
@@ -164,7 +163,6 @@ class RUSBoostClassifier(AdaBoostClassifier):
  array([...])
  """
 
- @_deprecate_positional_args
  def __init__(
  self,
  estimator=None,

imblearn/ensemble/tests/test_bagging.py

@@ -72,7 +72,6 @@ def test_balanced_bagging_classifier(estimator, params):
  )
  bag.predict(X_test)
  bag.predict_proba(X_test)
- bag.predict_log_proba(X_test)
  bag.score(X_test, y_test)
  if hasattr(estimator, "decision_function"):
  bag.decision_function(X_test)