chore: add support for usestdlibvars, wastedassign and zerologlint

Author: remyleone

.golangci.yml

@@ -23,7 +23,10 @@ linters:
  - goimports # In addition to fixing imports, goimports also formats your code in the same style as gofmt. [fast: true, auto-fix: true]
  - mirror # reports wrong mirror patterns of bytes/strings usage [fast: false, auto-fix: false]
  - unused #(megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
+ - usestdlibvars # A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false]
+ - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false]
  - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true]
+ - zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false]
 
 issues:
  max-issues-per-linter: 0

api/instance/v1/instance_metadata_sdk.go

@@ -38,7 +38,7 @@ func (meta *MetadataAPI) getMetadataUrl() string {
 for _, url := range []string{metadataAPIv4, metadataAPIv6} {
 http.DefaultClient.Timeout = 3 * time.Second
 resp, err := http.Get(url)
-if err == nil && resp.StatusCode == 200 {
+if err == nil && resp.StatusCode == http.StatusOK {
 meta.MetadataURL = &url
 return url
 }
@@ -259,7 +259,7 @@ func (meta *MetadataAPI) SetUserData(key string, value []byte) error {
 }).DialContext,
 },
 }
-request, err := http.NewRequest("PATCH", meta.getMetadataUrl()+"/user_data/"+key, bytes.NewBuffer(value))
+request, err := http.NewRequest(http.MethodPatch, meta.getMetadataUrl()+"/user_data/"+key, bytes.NewBuffer(value))
 if err != nil {
 return errors.Wrap(err, "error creating patch userdata request")
 }
@@ -298,7 +298,7 @@ func (meta *MetadataAPI) DeleteUserData(key string) error {
 }).DialContext,
 },
 }
-request, err := http.NewRequest("DELETE", meta.getMetadataUrl()+"/user_data/"+key, bytes.NewBufferString(""))
+request, err := http.NewRequest(http.MethodDelete, meta.getMetadataUrl()+"/user_data/"+key, bytes.NewBufferString(""))
 if err != nil {
 return errors.Wrap(err, "error creating delete userdata request")
 }

scw/errors_test.go

@@ -12,14 +12,14 @@ import (
 )
 
 func TestHasResponseErrorWithStatus200(t *testing.T) {
-res := &http.Response{StatusCode: 200}
+res := &http.Response{StatusCode: http.StatusOK}
 
 newErr := hasResponseError(res)
 testhelpers.AssertNoError(t, newErr)
 }
 
 func TestHasResponseErrorWithoutBody(t *testing.T) {
-res := &http.Response{StatusCode: 400}
+res := &http.Response{StatusCode: http.StatusBadRequest}
 
 newErr := hasResponseError(res)
 testhelpers.Assert(t, newErr != nil, "Should have error")