chore: add support for perfsprint and other linters (#2186)

Author: remyleone

.golangci.yml

@@ -36,6 +36,13 @@ linters:
  - grouper # An analyzer to analyze expression groups. [fast: true, auto-fix: false]
  - importas # Enforces consistent import aliases [fast: false, auto-fix: false]
  - mirror # reports wrong mirror patterns of bytes/strings usage [fast: false, auto-fix: false]
+ - nakedret # Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
+ - nolintlint # Reports ill-formed or insufficient nolint directives [fast: true, auto-fix: false]
+ - nosprintfhostport # Checks for misuse of Sprintf to construct a host with port in a URL. [fast: true, auto-fix: false]
+ - perfsprint # Checks that fmt.Sprintf can be replaced with a faster alternative. [fast: false, auto-fix: false]
+ - rowserrcheck # checks whether Err of rows is checked successfully [fast: false, auto-fix: false]
+ - sloglint # ensure consistent code style when using log/slog [fast: false, auto-fix: false]
+ - sqlclosecheck # Checks that sql.Rows and sql.Stmt are closed. [fast: false, auto-fix: false]
  - staticcheck #(megacheck): Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: false, auto-fix: false]
  - unused #(megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
  - usestdlibvars # A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false]

api/instance/v1/server_utils.go

@@ -196,21 +196,21 @@ func (s *API) GetServerUserData(req *GetServerUserDataRequest, opts ...scw.Reque
 req.Zone = defaultZone
 }
 
-if fmt.Sprint(req.Zone) == "" {
+if req.Zone == "" {
 return nil, errors.New("field Zone cannot be empty in request")
 }
 
-if fmt.Sprint(req.ServerID) == "" {
+if req.ServerID == "" {
 return nil, errors.New("field ServerID cannot be empty in request")
 }
 
-if fmt.Sprint(req.Key) == "" {
+if req.Key == "" {
 return nil, errors.New("field Key cannot be empty in request")
 }
 
 scwReq := &scw.ScalewayRequest{
 Method: "GET",
-Path: "/instance/v1/zones/" + fmt.Sprint(req.Zone) + "/servers/" + fmt.Sprint(req.ServerID) + "/user_data/" + fmt.Sprint(req.Key),
+Path: "/instance/v1/zones/" + fmt.Sprint(req.Zone) + "/servers/" + req.ServerID + "/user_data/" + req.Key,
 Headers: http.Header{},
 }
 
@@ -245,15 +245,15 @@ func (s *API) SetServerUserData(req *SetServerUserDataRequest, opts ...scw.Reque
 req.Zone = defaultZone
 }
 
-if fmt.Sprint(req.Zone) == "" {
+if req.Zone == "" {
 return errors.New("field Zone cannot be empty in request")
 }
 
-if fmt.Sprint(req.ServerID) == "" {
+if req.ServerID == "" {
 return errors.New("field ServerID cannot be empty in request")
 }
 
-if fmt.Sprint(req.Key) == "" {
+if req.Key == "" {
 return errors.New("field Key cannot be empty in request")
 }
 
@@ -263,7 +263,7 @@ func (s *API) SetServerUserData(req *SetServerUserDataRequest, opts ...scw.Reque
 
 scwReq := &scw.ScalewayRequest{
 Method: "PATCH",
-Path: "/instance/v1/zones/" + fmt.Sprint(req.Zone) + "/servers/" + fmt.Sprint(req.ServerID) + "/user_data/" + fmt.Sprint(req.Key),
+Path: "/instance/v1/zones/" + fmt.Sprint(req.Zone) + "/servers/" + req.ServerID + "/user_data/" + req.Key,
 Headers: http.Header{},
 }
 
@@ -304,7 +304,7 @@ func (s *API) GetAllServerUserData(req *GetAllServerUserDataRequest, opts ...scw
 return nil, errors.New("field Zone cannot be empty in request")
 }
 
-if fmt.Sprint(req.ServerID) == "" {
+if req.ServerID == "" {
 return nil, errors.New("field ServerID cannot be empty in request")
 }
 
@@ -357,11 +357,11 @@ func (s *API) SetAllServerUserData(req *SetAllServerUserDataRequest, opts ...scw
 req.Zone = defaultZone
 }
 
-if fmt.Sprint(req.Zone) == "" {
+if req.Zone == "" {
 return errors.New("field Zone cannot be empty in request")
 }
 
-if fmt.Sprint(req.ServerID) == "" {
+if req.ServerID == "" {
 return errors.New("field ServerID cannot be empty in request")
 }
 

internal/async/wait_test.go

@@ -1,7 +1,7 @@
 package async
 
 import (
-"fmt"
+"errors"
 "testing"
 "time"
 
@@ -71,7 +71,7 @@ func TestWaitSync(t *testing.T) {
 Timeout: time.Second,
 },
 expValue: nil,
-expErr: fmt.Errorf("timeout after 1s"),
+expErr: errors.New("timeout after 1s"),
 },
 {
 name: "With interval",
@@ -103,7 +103,7 @@ func TestWaitSync(t *testing.T) {
 IntervalStrategy: LinearIntervalStrategy(2 * time.Second),
 },
 expValue: nil,
-expErr: fmt.Errorf("timeout after 2s"),
+expErr: errors.New("timeout after 2s"),
 },
 }
 for _, c := range testsCases {

internal/testhelpers/httprecorder/recorder.go

@@ -46,7 +46,7 @@ func CreateRecordedScwClient(cassetteName string) (*scw.Client, *recorder.Record
 }
 
 // Setup recorder and scw client
-r, err := recorder.NewAsMode(fmt.Sprintf("testdata/%s", cassetteName), recorderMode, nil)
+r, err := recorder.NewAsMode("testdata/"+cassetteName, recorderMode, nil)
 if err != nil {
 return nil, nil, err
 }

scw/client.go

@@ -357,7 +357,7 @@ func (c *Client) doListAll(req *ScalewayRequest, res interface{}) (err error) {
 func (c *Client) doListLocalities(req *ScalewayRequest, res interface{}, localities []string) (err error) {
 path := req.Path
 if !strings.Contains(path, "%locality%") {
-return fmt.Errorf("request is not a valid locality request")
+return errors.New("request is not a valid locality request")
 }
 // Requests are parallelized
 responseMutex := sync.Mutex{}
@@ -418,7 +418,7 @@ func (c *Client) doListZones(req *ScalewayRequest, res interface{}, zones []Zone
 }
 }
 if !strings.Contains(req.Path, "%locality%") {
-return fmt.Errorf("request is not a valid zoned request")
+return errors.New("request is not a valid zoned request")
 }
 localities := make([]string, 0, len(zones))
 for _, zone := range zones {
@@ -449,7 +449,7 @@ func (c *Client) doListRegions(req *ScalewayRequest, res interface{}, regions []
 }
 }
 if !strings.Contains(req.Path, "%locality%") {
-return fmt.Errorf("request is not a valid zoned request")
+return errors.New("request is not a valid zoned request")
 }
 localities := make([]string, 0, len(regions))
 for _, region := range regions {

scw/custom_types.go

@@ -112,7 +112,7 @@ type Money struct {
 // - (value = 1.123456789, precision = 9) => Money{Units = 1, Nanos = 123456789}
 func NewMoneyFromFloat(value float64, currencyCode string, precision int) *Money {
 if precision > 9 {
-panic(fmt.Errorf("max precision is 9"))
+panic(errors.New("max precision is 9"))
 }
 
 strValue := strconv.FormatFloat(value, 'f', precision, 64)
@@ -206,7 +206,7 @@ func (tsp *TimeSeriesPoint) UnmarshalJSON(b []byte) error {
 }
 
 if len(point) != 2 {
-return fmt.Errorf("invalid point array")
+return errors.New("invalid point array")
 }
 
 strTimestamp, isStrTimestamp := point[0].(string)

scw/custom_types_test.go

@@ -2,7 +2,7 @@ package scw
 
 import (
 "encoding/json"
-"fmt"
+"errors"
 "io"
 "net"
 "strings"
@@ -269,7 +269,7 @@ func TestTimeSeries_UnmarshalJSON(t *testing.T) {
 {
 name: "with timestamp error",
 json: `{"name":"cpu_usage","points":[["2019/08/08T15-00-00Z",0.2]]}`,
-err: fmt.Errorf("2019/08/08T15-00-00Z timestamp is not in RFC 3339 format"),
+err: errors.New("2019/08/08T15-00-00Z timestamp is not in RFC 3339 format"),
 },
 }
 

scw/errors.go

@@ -61,7 +61,7 @@ func (e *ResponseError) UnmarshalJSON(b []byte) error {
 func (e *ResponseError) IsScwSdkError() {}
 
 func (e *ResponseError) Error() string {
-s := fmt.Sprintf("scaleway-sdk-go: http error %s", e.Status)
+s := "scaleway-sdk-go: http error " + e.Status
 
 if e.Resource != "" {
 s = fmt.Sprintf("%s: resource %s", s, e.Resource)
@@ -472,7 +472,7 @@ func NewInvalidClientOptionError(format string, a ...interface{}) *InvalidClient
 func (e InvalidClientOptionError) IsScwSdkError() {}
 
 func (e InvalidClientOptionError) Error() string {
-return fmt.Sprintf("scaleway-sdk-go: %s", e.errorType)
+return "scaleway-sdk-go: " + e.errorType
 }
 
 // ConfigFileNotFound indicates that the config file could not be found
@@ -537,7 +537,7 @@ func (r DeniedAuthenticationError) Error() string {
 case "expired":
 reason = method + " is expired"
 }
-return fmt.Sprintf("scaleway-sdk-go: denied authentication: %s", reason)
+return "scaleway-sdk-go: denied authentication: " + reason
 }
 
 func (r DeniedAuthenticationError) IsScwSdkError() {}
@@ -564,7 +564,7 @@ func (r PreconditionFailedError) Error() string {
 msg += ", " + r.HelpMessage
 }
 
-return fmt.Sprintf("scaleway-sdk-go: precondition failed: %s", msg)
+return "scaleway-sdk-go: precondition failed: " + msg
 }
 
 func (r PreconditionFailedError) IsScwSdkError() {}