Skip to content

Tracebacks from endpoint failures are propagated to client #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Tracebacks from endpoint failures are propagated to client #36

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0e2c498
rich formatting only takes strings
seanshi-scale Jun 27, 2022
d426ba2
python client async tracebacks
seanshi-scale Jun 27, 2022
c47de95
sync tracebacks
seanshi-scale Jun 27, 2022
74ecdae
remove handle_bad_response
seanshi-scale Jun 28, 2022
db26c2d
rm todo
seanshi-scale Jun 28, 2022
5aeb4ca
update version :D
seanshi-scale Jun 29, 2022
3fc02be
Merge branch 'master' into seanshi/task-tracebacks
seanshi-scale Jun 29, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rm todo
  • Loading branch information
@seanshi-scale
seanshi-scale committed Jun 28, 2022
commit db26c2de8afd0758454b7df80a7d3f59ae3bca2e
1 change: 0 additions & 1 deletion launch/model_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ def predict(self, request: EndpointRequest) -> EndpointResponse:
args=request.args,
return_pickled=request.return_pickled,
)
# TODO catch error response and populate traceback?
return EndpointResponse(
client=self.client,
status=raw_response.get("state"),
Copy link
Contributor

@syandroo syandroo Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consolidate on state vs status haha
Copy link
Contributor Author

@seanshi-scale seanshi-scale Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should tbh, I like status personally
Expand Down