Address review comments

Author: allanrenucci

compiler/src/dotty/tools/dotc/reporting/Reporter.scala

@@ -24,7 +24,7 @@ object Reporter {
  }
  }
 
- /** A reporter that ignores reports */
+ /** A reporter that ignores reports, and doesn't record errors */
  @sharable object NoReporter extends Reporter {
  def doReport(m: MessageContainer)(implicit ctx: Context) = ()
  override def report(m: MessageContainer)(implicit ctx: Context): Unit = ()
@@ -163,8 +163,10 @@ abstract class Reporter extends interfaces.ReporterResult {
  finally incompleteHandler = saved
  }
 
- var errorCount = 0
- var warningCount = 0
+ private[this] var _errorCount = 0
+ private[this] var _warningCount = 0
+ def errorCount = _errorCount
+ def warningCount = _warningCount
  def hasErrors = errorCount > 0
  def hasWarnings = warningCount > 0
  private[this] var errors: List[Error] = Nil
@@ -191,10 +193,10 @@ abstract class Reporter extends interfaces.ReporterResult {
  doReport(m)(ctx.addMode(Mode.Printing))
  m match {
  case m: ConditionalWarning if !m.enablingOption.value => unreportedWarnings(m.enablingOption.name) += 1
- case m: Warning => warningCount += 1
+ case m: Warning => _warningCount += 1
  case m: Error =>
  errors = m :: errors
- errorCount += 1
+ _errorCount += 1
  case m: Info => // nothing to do here
  // match error if d is something else
  }

compiler/src/dotty/tools/repl/JLineTerminal.scala

@@ -50,7 +50,8 @@ final class JLineTerminal extends java.io.Closeable {
  .completer(completer)
  .highlighter(new Highlighter)
  .parser(new Parser)
- .variable(SECONDARY_PROMPT_PATTERN, "%M")
+ .variable(SECONDARY_PROMPT_PATTERN, "%M") // A short word explaining what is "missing".
+ // This is supplied from the EOFError.getMissing() method
  .variable(LIST_MAX, 400) // ask user when number of completions exceed this limit (default is 100)
  .option(INSERT_TAB, true) // at the beginning of the line, insert tab instead of completing
  .option(AUTO_FRESH_LINE, true) // if not at start of line before prompt, move to new line