Revert "Followup fix to transparent inline conversion (#18130)"

This reverts commit 3de184c.

Author: nicolasstucki

compiler/src/dotty/tools/dotc/typer/ProtoTypes.scala

@@ -18,7 +18,6 @@ import ErrorReporting.*
 import util.SourceFile
 import TypeComparer.necessarySubType
 import dotty.tools.dotc.core.Flags.Transparent
-import dotty.tools.dotc.config.{ Feature, SourceVersion }
 
 import scala.annotation.internal.sharable
 import dotty.tools.dotc.util.Spans.{NoSpan, Span}
@@ -115,22 +114,9 @@ object ProtoTypes {
  * achieved by replacing expected type parameters with wildcards.
  */
  def constrainResult(meth: Symbol, mt: Type, pt: Type)(using Context): Boolean =
- if (Inlines.isInlineable(meth)) {
- // Stricter behaviour in 3.4+: do not apply `wildApprox` to non-transparent inlines
- if (Feature.sourceVersion.isAtLeast(SourceVersion.`3.4`)) {
- if (meth.is(Transparent)) {
- constrainResult(mt, wildApprox(pt))
- // do not constrain the result type of transparent inline methods
- true
- } else {
- constrainResult(mt, pt)
- }
- } else {
- // Best-effort to fix https://github.com/scala/scala3/issues/9685 in the 3.3.x series
- // while preserving source compatibility as much as possible
- val methodMatchedType = constrainResult(mt, wildApprox(pt))
- meth.is(Transparent) || methodMatchedType
- }
+ if (Inlines.isInlineable(meth) && meth.is(Transparent)) {
+ constrainResult(mt, wildApprox(pt))
+ true
  }
  else constrainResult(mt, pt)
  }