Skip to content

Commit caf9985

Browse files
armanbilgearmanbilge
committed
Address reviews, fix constants
1 parent 7f27f6c commit caf9985

File tree

14 files changed

+139
-33
lines changed

14 files changed

+139
-33
lines changed

‎api-reports/2_12.txt‎

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ AnimationEvent[JT] def stopPropagation(): Unit
111111
AnimationEvent[JT] def target: EventTarget
112112
AnimationEvent[JT] def timeStamp: Double
113113
AnimationEvent[JT] def `type`: String
114+
AppendMode[JT]
115+
AppendMode[SO] val segments: AppendMode
116+
AppendMode[SO] val sequence: AppendMode
114117
ApplicationCache[JO] val CHECKING: Int
115118
ApplicationCache[JO] val DOWNLOADING: Int
116119
ApplicationCache[JO] val IDLE: Int
@@ -1767,6 +1770,9 @@ Element[JC] def setAttributeNode(newAttr: Attr): Attr
17671770
Element[JC] def setAttributeNodeNS(newAttr: Attr): Attr
17681771
Element[JC] def tagName: String
17691772
Element[JC] var textContent: String
1773+
EndOfStreamError[JT]
1774+
EndOfStreamError[SO] val decode: EndOfStreamError
1775+
EndOfStreamError[SO] val network: EndOfStreamError
17701776
ErrorEvent[JT] def bubbles: Boolean
17711777
ErrorEvent[JT] def cancelBubble: Boolean
17721778
ErrorEvent[JT] def cancelable: Boolean
@@ -14743,11 +14749,11 @@ MediaSource[JC] def addSourceBuffer(mimeType: String): SourceBuffer
1474314749
MediaSource[JC] def clearLiveSeekableRange(): Unit
1474414750
MediaSource[JC] def dispatchEvent(evt: Event): Boolean
1474514751
MediaSource[JC] var duration: Double
14746-
MediaSource[JC] def endOfStream(error: String?): Unit
14752+
MediaSource[JC] def endOfStream(error: EndOfStreamError?): Unit
1474714753
MediaSource[JC] var onsourceclose: js.Function1[Event, Any]
1474814754
MediaSource[JC] var onsourceended: js.Function1[Event, Any]
1474914755
MediaSource[JC] var onsourceopen: js.Function1[Event, Any]
14750-
MediaSource[JC] def readyState: String
14756+
MediaSource[JC] def readyState: ReadyState
1475114757
MediaSource[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
1475214758
MediaSource[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
1475314759
MediaSource[JC] def removeSourceBuffer(sourceBuffer: SourceBuffer): Unit
@@ -15827,6 +15833,10 @@ ReadableStreamReader[JC] def cancel(reason: Any): js.Promise[Any]
1582715833
ReadableStreamReader[JC] def closed: js.Promise[ReadableStreamReader[T]]
1582815834
ReadableStreamReader[JC] def read(): js.Promise[Chunk[T]]
1582915835
ReadableStreamReader[JC] def releaseLock(): Unit
15836+
ReadyState[JT]
15837+
ReadyState[SO] val closed: ReadyState
15838+
ReadyState[SO] val ended: ReadyState
15839+
ReadyState[SO] val open: ReadyState
1583015840
ReferrerPolicy[JT]
1583115841
ReferrerPolicy[SO] val empty: ReferrerPolicy
1583215842
ReferrerPolicy[SO] val `no-referrer` = "no-referrer".asInstanceOf[ReferrerPolicy]
@@ -24056,7 +24066,7 @@ SourceBuffer[JT] var appendWindowStart: Double
2405624066
SourceBuffer[JT] def audioTracks: AudioTrackList
2405724067
SourceBuffer[JT] def buffered: TimeRanges
2405824068
SourceBuffer[JT] def dispatchEvent(evt: Event): Boolean
24059-
SourceBuffer[JT] var mode: String
24069+
SourceBuffer[JT] var mode: AppendMode
2406024070
SourceBuffer[JT] var onabort: js.Function1[Event, Any]
2406124071
SourceBuffer[JT] var onerror: js.Function1[Event, Any]
2406224072
SourceBuffer[JT] var onupdate: js.Function1[Event, Any]
@@ -24270,7 +24280,7 @@ TextTrack[JT] val inBandMetadataTrackDispatchType: String
2427024280
TextTrack[JT] var kind: String
2427124281
TextTrack[JT] var label: String
2427224282
TextTrack[JT] var language: String
24273-
TextTrack[JT] var mode: String
24283+
TextTrack[JT] var mode: TextTrackMode
2427424284
TextTrack[JT] var oncuechange: js.Function1[Event, _]
2427524285
TextTrack[JT] var onerror: js.Function1[ErrorEvent, _]
2427624286
TextTrack[JT] var onload: js.Function1[js.Any, _]
@@ -24301,6 +24311,10 @@ TextTrackList[JT] def length: Int
2430124311
TextTrackList[JT] var onaddtrack: js.Function1[Event, Any]
2430224312
TextTrackList[JT] var onchange: js.Function1[Event, Any]
2430324313
TextTrackList[JT] var onremovetrack: js.Function1[Event, Any]
24314+
TextTrackMode[JT]
24315+
TextTrackMode[SO] val disabled: TextTrackMode
24316+
TextTrackMode[SO] val hidden: TextTrackMode
24317+
TextTrackMode[SO] val showing: TextTrackMode
2430424318
TimeRanges[JC] def end(index: Int): Double
2430524319
TimeRanges[JC] def length: Int
2430624320
TimeRanges[JC] def start(index: Int): Double
@@ -25513,11 +25527,11 @@ experimental/intl/package[SO] @deprecated("use dom.intl.DateTimeFormat instead",
2551325527
experimental/intl/package[SO] @deprecated("use dom.intl.DateTimeFormatOptions instead", "2.0.0") val DateTimeFormatOptions = dom.intl.DateTimeFormatOptions
2551425528
experimental/intl/package[SO] @deprecated("use dom.intl.NumberFormat instead", "2.0.0") val NumberFormat = dom.intl.NumberFormat
2551525529
experimental/intl/package[SO] @deprecated("use dom.intl.NumberFormatOptions instead", "2.0.0") val NumberFormatOptions = dom.intl.NumberFormatOptions
25516-
experimental/mediastream/package[SO] type AppendMode = String (@deprecated in 2.0.0)
25530+
experimental/mediastream/package[SO] type AppendMode = dom.AppendMode (@deprecated in 2.0.0)
2551725531
experimental/mediastream/package[SO] type AudioTrack = dom.AudioTrack (@deprecated in 2.0.0)
2551825532
experimental/mediastream/package[SO] type AudioTrackList = dom.AudioTrackList (@deprecated in 2.0.0)
25519-
experimental/mediastream/package[SO] type BufferSource = js.typedarray.ArrayBufferView | js.typedarray.ArrayBuffer (@deprecated in 2.0.0)
25520-
experimental/mediastream/package[SO] type EndOfStreamError = String (@deprecated in 2.0.0)
25533+
experimental/mediastream/package[SO] type BufferSource = dom.BufferSource (@deprecated in 2.0.0)
25534+
experimental/mediastream/package[SO] type EndOfStreamError = dom.EndOfStreamError (@deprecated in 2.0.0)
2552125535
experimental/mediastream/package[SO] type ImageCapture = dom.ImageCapture (@deprecated in 2.0.0)
2552225536
experimental/mediastream/package[SO] type MediaDeviceInfo = dom.MediaDeviceInfo (@deprecated in 2.0.0)
2552325537
experimental/mediastream/package[SO] type MediaDeviceKind = dom.MediaDeviceKind (@deprecated in 2.0.0)
@@ -25533,14 +25547,14 @@ experimental/mediastream/package[SO] type MediaTrackConstraintSet = dom.MediaTra
2553325547
experimental/mediastream/package[SO] type MediaTrackConstraints = dom.MediaTrackConstraints (@deprecated in 2.0.0)
2553425548
experimental/mediastream/package[SO] type MediaTrackSettings = dom.MediaTrackSettings (@deprecated in 2.0.0)
2553525549
experimental/mediastream/package[SO] type MediaTrackSupportedConstraints = dom.MediaTrackSupportedConstraints (@deprecated in 2.0.0)
25536-
experimental/mediastream/package[SO] type ReadyState = String (@deprecated in 2.0.0)
25550+
experimental/mediastream/package[SO] type ReadyState = dom.ReadyState (@deprecated in 2.0.0)
2553725551
experimental/mediastream/package[SO] type SourceBuffer = dom.SourceBuffer (@deprecated in 2.0.0)
2553825552
experimental/mediastream/package[SO] type SourceBufferList = dom.SourceBufferList (@deprecated in 2.0.0)
2553925553
experimental/mediastream/package[SO] type TextTrack = dom.TextTrack (@deprecated in 2.0.0)
2554025554
experimental/mediastream/package[SO] type TextTrackCue = dom.TextTrackCue (@deprecated in 2.0.0)
2554125555
experimental/mediastream/package[SO] type TextTrackCueList = dom.TextTrackCueList (@deprecated in 2.0.0)
2554225556
experimental/mediastream/package[SO] type TextTrackList = dom.TextTrackList (@deprecated in 2.0.0)
25543-
experimental/mediastream/package[SO] type TextTrackMode = String (@deprecated in 2.0.0)
25557+
experimental/mediastream/package[SO] type TextTrackMode = dom.TextTrackMode (@deprecated in 2.0.0)
2554425558
experimental/mediastream/package[SO] type VideoTrack = dom.VideoTrack (@deprecated in 2.0.0)
2554525559
experimental/mediastream/package[SO] type VideoTrackList = dom.VideoTrackList (@deprecated in 2.0.0)
2554625560
experimental/mediastream/package[SO] @deprecated("use dom.MediaDeviceInfo instead", "2.0.0") val MediaDeviceInfo = dom.MediaDeviceInfo

‎api-reports/2_13.txt‎

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ AnimationEvent[JT] def stopPropagation(): Unit
111111
AnimationEvent[JT] def target: EventTarget
112112
AnimationEvent[JT] def timeStamp: Double
113113
AnimationEvent[JT] def `type`: String
114+
AppendMode[JT]
115+
AppendMode[SO] val segments: AppendMode
116+
AppendMode[SO] val sequence: AppendMode
114117
ApplicationCache[JO] val CHECKING: Int
115118
ApplicationCache[JO] val DOWNLOADING: Int
116119
ApplicationCache[JO] val IDLE: Int
@@ -1767,6 +1770,9 @@ Element[JC] def setAttributeNode(newAttr: Attr): Attr
17671770
Element[JC] def setAttributeNodeNS(newAttr: Attr): Attr
17681771
Element[JC] def tagName: String
17691772
Element[JC] var textContent: String
1773+
EndOfStreamError[JT]
1774+
EndOfStreamError[SO] val decode: EndOfStreamError
1775+
EndOfStreamError[SO] val network: EndOfStreamError
17701776
ErrorEvent[JT] def bubbles: Boolean
17711777
ErrorEvent[JT] def cancelBubble: Boolean
17721778
ErrorEvent[JT] def cancelable: Boolean
@@ -14743,11 +14749,11 @@ MediaSource[JC] def addSourceBuffer(mimeType: String): SourceBuffer
1474314749
MediaSource[JC] def clearLiveSeekableRange(): Unit
1474414750
MediaSource[JC] def dispatchEvent(evt: Event): Boolean
1474514751
MediaSource[JC] var duration: Double
14746-
MediaSource[JC] def endOfStream(error: String?): Unit
14752+
MediaSource[JC] def endOfStream(error: EndOfStreamError?): Unit
1474714753
MediaSource[JC] var onsourceclose: js.Function1[Event, Any]
1474814754
MediaSource[JC] var onsourceended: js.Function1[Event, Any]
1474914755
MediaSource[JC] var onsourceopen: js.Function1[Event, Any]
14750-
MediaSource[JC] def readyState: String
14756+
MediaSource[JC] def readyState: ReadyState
1475114757
MediaSource[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
1475214758
MediaSource[JC] def removeEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit
1475314759
MediaSource[JC] def removeSourceBuffer(sourceBuffer: SourceBuffer): Unit
@@ -15827,6 +15833,10 @@ ReadableStreamReader[JC] def cancel(reason: Any): js.Promise[Any]
1582715833
ReadableStreamReader[JC] def closed: js.Promise[ReadableStreamReader[T]]
1582815834
ReadableStreamReader[JC] def read(): js.Promise[Chunk[T]]
1582915835
ReadableStreamReader[JC] def releaseLock(): Unit
15836+
ReadyState[JT]
15837+
ReadyState[SO] val closed: ReadyState
15838+
ReadyState[SO] val ended: ReadyState
15839+
ReadyState[SO] val open: ReadyState
1583015840
ReferrerPolicy[JT]
1583115841
ReferrerPolicy[SO] val empty: ReferrerPolicy
1583215842
ReferrerPolicy[SO] val `no-referrer` = "no-referrer".asInstanceOf[ReferrerPolicy]
@@ -24056,7 +24066,7 @@ SourceBuffer[JT] var appendWindowStart: Double
2405624066
SourceBuffer[JT] def audioTracks: AudioTrackList
2405724067
SourceBuffer[JT] def buffered: TimeRanges
2405824068
SourceBuffer[JT] def dispatchEvent(evt: Event): Boolean
24059-
SourceBuffer[JT] var mode: String
24069+
SourceBuffer[JT] var mode: AppendMode
2406024070
SourceBuffer[JT] var onabort: js.Function1[Event, Any]
2406124071
SourceBuffer[JT] var onerror: js.Function1[Event, Any]
2406224072
SourceBuffer[JT] var onupdate: js.Function1[Event, Any]
@@ -24270,7 +24280,7 @@ TextTrack[JT] val inBandMetadataTrackDispatchType: String
2427024280
TextTrack[JT] var kind: String
2427124281
TextTrack[JT] var label: String
2427224282
TextTrack[JT] var language: String
24273-
TextTrack[JT] var mode: String
24283+
TextTrack[JT] var mode: TextTrackMode
2427424284
TextTrack[JT] var oncuechange: js.Function1[Event, _]
2427524285
TextTrack[JT] var onerror: js.Function1[ErrorEvent, _]
2427624286
TextTrack[JT] var onload: js.Function1[js.Any, _]
@@ -24301,6 +24311,10 @@ TextTrackList[JT] def length: Int
2430124311
TextTrackList[JT] var onaddtrack: js.Function1[Event, Any]
2430224312
TextTrackList[JT] var onchange: js.Function1[Event, Any]
2430324313
TextTrackList[JT] var onremovetrack: js.Function1[Event, Any]
24314+
TextTrackMode[JT]
24315+
TextTrackMode[SO] val disabled: TextTrackMode
24316+
TextTrackMode[SO] val hidden: TextTrackMode
24317+
TextTrackMode[SO] val showing: TextTrackMode
2430424318
TimeRanges[JC] def end(index: Int): Double
2430524319
TimeRanges[JC] def length: Int
2430624320
TimeRanges[JC] def start(index: Int): Double
@@ -25513,11 +25527,11 @@ experimental/intl/package[SO] @deprecated("use dom.intl.DateTimeFormat instead",
2551325527
experimental/intl/package[SO] @deprecated("use dom.intl.DateTimeFormatOptions instead", "2.0.0") val DateTimeFormatOptions = dom.intl.DateTimeFormatOptions
2551425528
experimental/intl/package[SO] @deprecated("use dom.intl.NumberFormat instead", "2.0.0") val NumberFormat = dom.intl.NumberFormat
2551525529
experimental/intl/package[SO] @deprecated("use dom.intl.NumberFormatOptions instead", "2.0.0") val NumberFormatOptions = dom.intl.NumberFormatOptions
25516-
experimental/mediastream/package[SO] type AppendMode = String (@deprecated in 2.0.0)
25530+
experimental/mediastream/package[SO] type AppendMode = dom.AppendMode (@deprecated in 2.0.0)
2551725531
experimental/mediastream/package[SO] type AudioTrack = dom.AudioTrack (@deprecated in 2.0.0)
2551825532
experimental/mediastream/package[SO] type AudioTrackList = dom.AudioTrackList (@deprecated in 2.0.0)
25519-
experimental/mediastream/package[SO] type BufferSource = js.typedarray.ArrayBufferView | js.typedarray.ArrayBuffer (@deprecated in 2.0.0)
25520-
experimental/mediastream/package[SO] type EndOfStreamError = String (@deprecated in 2.0.0)
25533+
experimental/mediastream/package[SO] type BufferSource = dom.BufferSource (@deprecated in 2.0.0)
25534+
experimental/mediastream/package[SO] type EndOfStreamError = dom.EndOfStreamError (@deprecated in 2.0.0)
2552125535
experimental/mediastream/package[SO] type ImageCapture = dom.ImageCapture (@deprecated in 2.0.0)
2552225536
experimental/mediastream/package[SO] type MediaDeviceInfo = dom.MediaDeviceInfo (@deprecated in 2.0.0)
2552325537
experimental/mediastream/package[SO] type MediaDeviceKind = dom.MediaDeviceKind (@deprecated in 2.0.0)
@@ -25533,14 +25547,14 @@ experimental/mediastream/package[SO] type MediaTrackConstraintSet = dom.MediaTra
2553325547
experimental/mediastream/package[SO] type MediaTrackConstraints = dom.MediaTrackConstraints (@deprecated in 2.0.0)
2553425548
experimental/mediastream/package[SO] type MediaTrackSettings = dom.MediaTrackSettings (@deprecated in 2.0.0)
2553525549
experimental/mediastream/package[SO] type MediaTrackSupportedConstraints = dom.MediaTrackSupportedConstraints (@deprecated in 2.0.0)
25536-
experimental/mediastream/package[SO] type ReadyState = String (@deprecated in 2.0.0)
25550+
experimental/mediastream/package[SO] type ReadyState = dom.ReadyState (@deprecated in 2.0.0)
2553725551
experimental/mediastream/package[SO] type SourceBuffer = dom.SourceBuffer (@deprecated in 2.0.0)
2553825552
experimental/mediastream/package[SO] type SourceBufferList = dom.SourceBufferList (@deprecated in 2.0.0)
2553925553
experimental/mediastream/package[SO] type TextTrack = dom.TextTrack (@deprecated in 2.0.0)
2554025554
experimental/mediastream/package[SO] type TextTrackCue = dom.TextTrackCue (@deprecated in 2.0.0)
2554125555
experimental/mediastream/package[SO] type TextTrackCueList = dom.TextTrackCueList (@deprecated in 2.0.0)
2554225556
experimental/mediastream/package[SO] type TextTrackList = dom.TextTrackList (@deprecated in 2.0.0)
25543-
experimental/mediastream/package[SO] type TextTrackMode = String (@deprecated in 2.0.0)
25557+
experimental/mediastream/package[SO] type TextTrackMode = dom.TextTrackMode (@deprecated in 2.0.0)
2554425558
experimental/mediastream/package[SO] type VideoTrack = dom.VideoTrack (@deprecated in 2.0.0)
2554525559
experimental/mediastream/package[SO] type VideoTrackList = dom.VideoTrackList (@deprecated in 2.0.0)
2554625560
experimental/mediastream/package[SO] @deprecated("use dom.MediaDeviceInfo instead", "2.0.0") val MediaDeviceInfo = dom.MediaDeviceInfo

‎src/main/scala-2/org/scalajs/dom/AppendMode.scala‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package org.scalajs.dom
2+
3+
import scala.scalajs.js
4+
5+
@js.native
6+
sealed trait AppendMode extends js.Any
7+
8+
object AppendMode {
9+
val segments: AppendMode = "segments".asInstanceOf[AppendMode]
10+
val sequence: AppendMode = "sequence".asInstanceOf[AppendMode]
11+
}

‎src/main/scala-2/org/scalajs/dom/EndOfStreamError.scala‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package org.scalajs.dom
2+
3+
import scala.scalajs.js
4+
5+
@js.native
6+
sealed trait EndOfStreamError extends js.Any
7+
8+
object EndOfStreamError {
9+
val decode: EndOfStreamError = "decode".asInstanceOf[EndOfStreamError]
10+
val network: EndOfStreamError = "network".asInstanceOf[EndOfStreamError]
11+
}

‎src/main/scala-2/org/scalajs/dom/ReadyState.scala‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package org.scalajs.dom
2+
3+
import scala.scalajs.js
4+
5+
@js.native
6+
sealed trait ReadyState extends js.Any
7+
8+
object ReadyState {
9+
val closed: ReadyState = "closed".asInstanceOf[ReadyState]
10+
val ended: ReadyState = "ended".asInstanceOf[ReadyState]
11+
val open: ReadyState = "open".asInstanceOf[ReadyState]
12+
}

‎src/main/scala-2/org/scalajs/dom/TextTrackMode.scala‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package org.scalajs.dom
2+
3+
import scala.scalajs.js
4+
5+
@js.native
6+
sealed trait TextTrackMode extends js.Any
7+
8+
object TextTrackMode {
9+
val disabled: TextTrackMode = "disabled".asInstanceOf[TextTrackMode]
10+
val hidden: TextTrackMode = "hidden".asInstanceOf[TextTrackMode]
11+
val showing: TextTrackMode = "showing".asInstanceOf[TextTrackMode]
12+
}

‎src/main/scala-3/org/scalajs/dom/AppendMode.scala‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package org.scalajs.dom
2+
3+
opaque type AppendMode = String
4+
5+
object AppendMode {
6+
val segments: AppendMode = "segments"
7+
val sequence: AppendMode = "sequence"
8+
}

‎src/main/scala-3/org/scalajs/dom/EndOfStreamError.scala‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package org.scalajs.dom
2+
3+
opaque type EndOfStreamError = String
4+
5+
object EndOfStreamError {
6+
val decode: EndOfStreamError = "decode"
7+
val network: EndOfStreamError = "network"
8+
}

‎src/main/scala-3/org/scalajs/dom/ReadyState.scala‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package org.scalajs.dom
2+
3+
opaque type ReadyState = String
4+
5+
object ReadyState {
6+
val closed: ReadyState = "closed"
7+
val ended: ReadyState = "ended"
8+
val open: ReadyState = "open"
9+
}

‎src/main/scala-3/org/scalajs/dom/TextTrackMode.scala‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package org.scalajs.dom
2+
3+
opaque type TextTrackMode = String
4+
5+
object TextTrackMode {
6+
val disabled: TextTrackMode = "disabled"
7+
val hidden: TextTrackMode = "hidden"
8+
val showing: TextTrackMode = "showing"
9+
}

0 commit comments

Comments
 (0)