Skip to content

Commit 74370d1

Browse files
committed
perf: lazy load each module, update eslint config
1 parent c056a65 commit 74370d1

File tree

5 files changed

+25
-11
lines changed

5 files changed

+25
-11
lines changed

.eslintrc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
{
22
"env": {
3-
"es6": true
3+
"es6": true,
4+
"node": true
45
},
56
"extends": ["eslint:recommended", "plugin:react/recommended"],
67
"parser": "babel-eslint",
78
"parserOptions": {
89
"ecmaVersion": 6
910
},
1011
"plugins": [
11-
"react"
12+
"react",
13+
"react-native"
1214
],
1315
"rules": {
1416
"comma-dangle": ["error", "always-multiline"],

RNAdMobInterstitial.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@ const addEventListener = (event, handler) => {
3030
}
3131
_subscriptions.set(handler, listener);
3232
return {
33-
remove: () => removeEventListener(event, handler)
33+
remove: () => removeEventListener(event, handler),
3434
};
3535
} else {
36+
// eslint-disable-next-line no-console
3637
console.warn(`Trying to subscribe to unknown event: "${event}"`);
3738
return {
3839
remove: () => {},

RNAdMobRewarded.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,10 @@ const addEventListener = (event, handler) => {
3232
}
3333
_subscriptions.set(handler, listener);
3434
return {
35-
remove: () => removeEventListener(event, handler)
35+
remove: () => removeEventListener(event, handler),
3636
};
3737
} else {
38+
// eslint-disable-next-line no-console
3839
console.warn(`Trying to subscribe to unknown event: "${event}"`);
3940
return {
4041
remove: () => {},

index.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
1-
import AdMobBanner from './RNAdMobBanner';
2-
import AdMobInterstitial from './RNAdMobInterstitial';
3-
import PublisherBanner from './RNPublisherBanner';
4-
import AdMobRewarded from './RNAdMobRewarded';
5-
6-
export { AdMobBanner, AdMobInterstitial, PublisherBanner, AdMobRewarded };
1+
/* eslint-disable global-require */
2+
module.exports = {
3+
get AdMobBanner() {
4+
return require('./RNAdMobBanner').default;
5+
},
6+
get AdMobInterstitial() {
7+
return require('./RNAdMobInterstitial').default;
8+
},
9+
get PublisherBanner() {
10+
return require('./RNPublisherBanner').default;
11+
},
12+
get AdMobRewarded() {
13+
return require('./RNAdMobRewarded').default;
14+
},
15+
};

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"devDependencies": {
1919
"babel-eslint": "^7.2.3",
2020
"eslint": "^4.3.0",
21-
"eslint-plugin-react": "^7.1.0"
21+
"eslint-plugin-react": "^7.1.0",
22+
"eslint-plugin-react-native": "^3.2.0"
2223
}
2324
}

0 commit comments

Comments
 (0)