Skip to content

Commit dce3adb

Browse files
committed
Re-ignore tests, clarify reasons
1 parent 8e26905 commit dce3adb

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

java/client/test/org/openqa/selenium/WindowTest.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,9 @@ public void testCanMaximizeTheWindow() throws InterruptedException {
143143
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
144144
// though others aren't defined in org.openqa.selenium.Platform).
145145
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
146+
assumeNotLinuxAtSauce();
146147

147-
changeSizeTo(new Dimension(450, 275));
148+
changeSizeTo(new Dimension(450, 273));
148149
maximize();
149150
}
150151

@@ -155,9 +156,10 @@ public void testCanMaximizeTheWindowFromFrame() throws InterruptedException {
155156
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
156157
// though others aren't defined in org.openqa.selenium.Platform).
157158
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
159+
assumeNotLinuxAtSauce();
158160

159161
driver.get(pages.framesetPage);
160-
changeSizeTo(new Dimension(450, 275));
162+
changeSizeTo(new Dimension(450, 274));
161163

162164
driver.switchTo().frame("fourth");
163165
maximize();
@@ -170,6 +172,7 @@ public void testCanMaximizeTheWindowFromIframe() throws InterruptedException {
170172
// Browser window cannot be resized or moved on ANDROID (and most mobile platforms
171173
// though others aren't defined in org.openqa.selenium.Platform).
172174
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(ANDROID));
175+
assumeNotLinuxAtSauce();
173176

174177
driver.get(pages.iframePage);
175178
changeSizeTo(new Dimension(450, 275));
@@ -267,4 +270,14 @@ public Boolean apply(WebDriver driver) {
267270
}
268271
};
269272
}
273+
274+
private void assumeNotLinuxAtSauce() {
275+
// Tests that maximize browser window used to fail when Sauce didn't run a window manager
276+
// on Linux. 2015-07-16, they still fail although Sauce reportedly runs metacity.
277+
// Chrome/Linux: simply fail.
278+
// Firefox/Linux: FirefoxDriver finally report a changed window size 22 seconds after replying
279+
// the maximize command, but video never shows the maximized window.
280+
assumeFalse(TestUtilities.getEffectivePlatform(driver).is(LINUX) && SauceDriver.shouldUseSauce());
281+
}
282+
270283
}

0 commit comments

Comments
 (0)