Skip to content

Commit ee2e9f2

Browse files
committed
require MSBuild 16 or greater, bump version
1 parent 4c4d760 commit ee2e9f2

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

src/InheritDoc/InheritDoc.csproj

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,34 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<VersionPrefix>1.4.0</VersionPrefix>
5-
<TargetFrameworks>netstandard2.0;net46</TargetFrameworks>
4+
<VersionPrefix>2.0.0</VersionPrefix>
5+
<TargetFrameworks>netstandard2.0</TargetFrameworks>
66
</PropertyGroup>
77

88
<PropertyGroup>
9+
<MinClientVersion>5.0</MinClientVersion>
910
<DevelopmentDependency>true</DevelopmentDependency>
1011
<BuildOutputTargetFolder>tools</BuildOutputTargetFolder>
1112
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
1213
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
1314
</PropertyGroup>
1415

1516
<ItemGroup>
16-
<None Include="package\build\*" Pack="true" PackagePath="build;buildMultiTargeting" />
17+
<None Include="package\build\*" Pack="true" PackagePath="build" />
1718
<None Include="package\*" Pack="true" PackagePath="tools" />
1819
<None Include="$(OutputPath)\*\Mono.Cecil.dll" Pack="true" PackagePath="tools" />
19-
<None Include="$(OutputPath)\*\System.ValueTuple.dll" Pack="true" PackagePath="tools" />
2020
</ItemGroup>
2121

2222
<ItemGroup>
23-
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.9.20" />
23+
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="16.0.461" />
2424
<PackageReference Include="Mono.Cecil" Version="0.11.5" PrivateAssets="all" />
25-
<PackageReference Condition="$(DefineConstants.Contains('NETFRAMEWORK'))" Include="System.ValueTuple" Version="4.5.0" />
2625
<!-- these are for use in the test project, downloaded here to avoid version conflicts when building tests -->
2726
<PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[7.0.0]" />
2827
<PackageDownload Include="Microsoft.NETFramework.ReferenceAssemblies.net48" Version="[1.0.0]" />
2928
</ItemGroup>
3029

3130
<Target Name="VerifyPackDependencies" BeforeTargets="GenerateNuspec">
32-
<Error Condition="@(None->WithMetadataValue('Pack', 'true')->WithMetadataValue('Filename', 'Mono.Cecil')->Count()) != 2" Text="Dependencies were not present for pack. Start build again." />
31+
<Error Condition="@(None->WithMetadataValue('Pack', 'true')->WithMetadataValue('Filename', 'Mono.Cecil')->Count()) != 1" Text="Dependencies were not present for pack. Start build again." />
3332
</Target>
3433

3534
</Project>

src/InheritDoc/package/build/SauceControl.InheritDoc.props

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22
<Project>
33

44
<PropertyGroup>
5-
<_InheritDocTaskTfm Condition="'$(MSBuildRuntimeType)'!='Core'">net46</_InheritDocTaskTfm>
6-
<_InheritDocTaskTfm Condition="'$(MSBuildRuntimeType)'=='Core'">netstandard2.0</_InheritDocTaskTfm>
7-
<_InheritDocTaskLib>$(MSBuildThisFileDirectory)..\tools\$(_InheritDocTaskTfm)\SauceControl.InheritDoc.dll</_InheritDocTaskLib>
5+
<_InheritDocTaskLib>$(MSBuildThisFileDirectory)..\tools\netstandard2.0\SauceControl.InheritDoc.dll</_InheritDocTaskLib>
86
<_InheritDocNetStandardFallback>$(MSBuildThisFileDirectory)..\tools\netstandard.xml.gz</_InheritDocNetStandardFallback>
97
</PropertyGroup>
108

src/InheritDoc/package/build/SauceControl.InheritDoc.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
<CopyDocumentationFileToOutputDirectory>false</CopyDocumentationFileToOutputDirectory>
2020
</PropertyGroup>
2121

22+
<Warning Condition="'$(MSBuildVersion)'=='' or '$(MSBuildVersion)'&lt;'16.0'" Code="IDT900" Text="InheritDoc is not compatible with this MSBuild version. Use a 1.x version of the package if you need VS 2017 support." />
2223
<Warning Condition="'$(_InheritDocCopyFile)'!='true'" Code="IDT901" Text="CopyDocumentationFileToOutputDirectory is set to false, so InheritDoc will not write to the output directory. You should either set InheritDocEnabled to false or CopyDocumentationFileToOutputDirectory to true." />
2324
<Message Condition="'$(_InheritDocCopyFile)'=='true'" Importance="normal" Text="InheritDoc processing file: @(DocFileItem->'%(Filename)%(Extension)')" />
2425

0 commit comments

Comments
 (0)