Skip to content

Commit ab86370

Browse files
committed
Minor cleanup
1 parent 5f3e1be commit ab86370

File tree

3 files changed

+3
-25
lines changed

3 files changed

+3
-25
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<canteen.plugin.version>1.1.0</canteen.plugin.version>
7171

7272
<!-- Dependency Versions -->
73-
<reactive.streams.version>1.0.3</reactive.streams.version>
73+
<reactive.streams.version>1.0.4</reactive.streams.version>
7474
<grpc.version>1.42.1</grpc.version>
7575
<protoc.version>3.19.1</protoc.version> <!-- Same version as grpc-proto -->
7676
<jprotoc.version>1.2.0</jprotoc.version>

reactor/reactor-grpc-stub/pom.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,6 @@
6767
<artifactId>mockito-core</artifactId>
6868
<scope>test</scope>
6969
</dependency>
70-
<!-- https://mvnrepository.com/artifact/org.slf4j/slf4j-api -->
71-
<dependency>
72-
<groupId>org.slf4j</groupId>
73-
<artifactId>slf4j-api</artifactId>
74-
<version>1.7.36</version>
75-
<scope>test</scope>
76-
</dependency>
77-
<dependency>
78-
<groupId>ch.qos.logback</groupId>
79-
<artifactId>logback-classic</artifactId>
80-
<version>1.2.10</version>
81-
<scope>test</scope>
82-
</dependency>
8370
</dependencies>
8471

8572
<build>

reactor/reactor-grpc-stub/src/test/java/com/salesforce/reactorgrpc/stub/ReactorClientStreamObserverAndPublisherTest.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
package com.salesforce.reactorgrpc.stub;
88

99
import org.junit.jupiter.api.Test;
10-
import org.slf4j.Logger;
11-
import org.slf4j.LoggerFactory;
1210
import reactor.core.Fuseable;
1311
import reactor.core.publisher.Flux;
1412
import reactor.core.scheduler.Schedulers;
@@ -22,7 +20,6 @@
2220

2321

2422
public class ReactorClientStreamObserverAndPublisherTest {
25-
private static final Logger log = LoggerFactory.getLogger(ReactorClientStreamObserverAndPublisherTest.class.getName());
2623

2724
private static final int DEFAULT_CHUNK_SIZE = 512;
2825
private static final int PART_OF_CHUNK = DEFAULT_CHUNK_SIZE * 2 / 3;
@@ -76,18 +73,12 @@ public void discardQueueTest() {
7673
AtomicBoolean firstHandled = new AtomicBoolean();
7774
Flux<Integer> consumer =
7875
Flux.from(processor)
79-
.doOnDiscard(Integer.class, i -> {
80-
log.info("Processor: discarding {}", i);
81-
discardedByObserverAndPublisher.add(i);
82-
})
76+
.doOnDiscard(Integer.class, discardedByObserverAndPublisher::add)
8377
.log("processor")
8478
.limitRate(1)
8579
.publishOn(Schedulers.parallel())
8680
.limitRate(1)
87-
.doOnDiscard(Integer.class, i -> {
88-
log.info("publishOn: discarding {}", i);
89-
discardedByPublishOn.add(i);
90-
})
81+
.doOnDiscard(Integer.class, discardedByPublishOn::add)
9182
.<Integer>handle((i, sink) -> {
9283
if (firstHandled.compareAndSet(false, true)) {
9384
try {

0 commit comments

Comments
 (0)