Skip to content

Conversation

chinedufn
Copy link
Contributor

Closes #525

Copy link
Contributor Author

@chinedufn chinedufn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let some PR notes - ready for review!

@chinedufn
Copy link
Contributor Author

Mmmm I see the lockfile is used to know what version of wasm-bindgen to download... Cool adding that stuff back

 Thanks! Co-Authored-By: chinedufn <frankie.nwafili@gmail.com>
Copy link
Contributor

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me! thank you! waiting on merge for @fitzgen's review

Copy link
Contributor

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a bunch @chinedufn :)

@@ -0,0 +1,56 @@
# wasm-pack test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@fitzgen fitzgen merged commit 4c4272c into drager:master Jan 28, 2019
@chinedufn chinedufn deleted the pass-through branch January 28, 2019 18:23
@fitzgen fitzgen added the TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog - feature TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly

4 participants