Add the UnwrapThrowExt<T> trait #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
An extension trait for `Option<T>` and `Result<T, E>` for unwraping the `T` value, or throwing a JS error if it is not available. These methods should have a smaller code size footprint than the normal `Option::unwrap` and `Option::expect` methods, but they are specific to working with wasm and JS. On non-wasm32 targets, defaults to the normal unwrap/expect calls.
| @alexcrichton any idea what's up with the gc tests? https://travis-ci.com/rustwasm/wasm-bindgen/jobs/174516547#L748-L784 |
| Oh that's paritytech/parity-wasm#264, nothing to worry about there! |
alexcrichton approved these changes Feb 1, 2019
fitzgen added the TWiRaWA 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
An extension trait for
Option<T>andResult<T, E>for unwraping theTvalue, or throwing a JS error if it is not available.These methods should have a smaller code size footprint than the normal
Option::unwrapandOption::expectmethods, but they are specific to working with wasm and JS.On non-wasm32 targets, defaults to the normal unwrap/expect calls.