Add flag to build.py for disabling KVM #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've recently had the need to build and run the project on Windows using the Windows Subsystem for Linux, and I didn't encounter many blockers. The only problem is that QEMU would try to use KVM, which is currently broken in WSL. This PR adds a new flag to the test runner to allow selectively disabling hardware acceleration.
With this change,
./build.py run --disable-kvm --ci --headlessruns all the tests successfully under WSL2 on Windows 10. Unfortunately, trying to run the tests excluded from CI results in failures, suggesting that QEMU on WSL has some similar bugs.