Linear regression example #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LukeMathWalker added the examples This was referenced Jul 17, 2019
munckymagik reviewed Jul 20, 2019
| Very nice work.
One option would be to break out a dedicated examples repo. Then we could focus on organising by use-case and not need to worry about which For example, the actix examples repo. |
Member Author
| That is indeed a very good idea. It could be a proto-cookbook. |
munckymagik reviewed Jul 20, 2019
munckymagik approved these changes Jul 20, 2019
termoshtt approved these changes Jul 27, 2019
| /// to match the training data distribution. | ||
| /// | ||
| /// `self` is modified in place, nothing is returned. | ||
| pub fn fit<A, B>(&mut self, X: ArrayBase<A, Ix2>, y: ArrayBase<B, Ix1>) |
Member
There was a problem hiding this comment.
x and y should be refence x: &ArrayBase<A, Ix2>
Member
Good idea :) |
Member Author
| Closing this PR - I have moved to the example to the new repository ( https://github.com/rust-ndarray/ndarray-examples ). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I have started to port some very simple Python code to Rust to explore the ergonomics of what is currently available for ML and better understand the design challenges (see rust-ml/classical-ml-discussion#2 (comment)).
This is quite an easy example that brings together
ndarray-linalg,ndarrayandndarray-stats(which is what we were looking for in rust-ndarray/ndarray-stats#47 ) - right now I lean towards the idea of hosting it in theexamplescollection forndarray-linalg, but I am open to suggestions.What do you think? @jturner314 @termoshtt @munckymagik
(Also, do you think it is actually a useful example to have in any of those crates?)