Propagate target data of compile benchmarks to the frontend

Author: Kobzol

site/frontend/src/pages/compare/compile/common.ts

@@ -72,6 +72,7 @@ export const defaultCompileFilter: CompileBenchmarkFilter = {
 export type Profile = "check" | "debug" | "opt" | "doc";
 export type CodegenBackend = "llvm" | "cranelift";
 export type Category = "primary" | "secondary";
+export type Target = "x86_64-unknown-linux-gnu";
 
 export type CompileBenchmarkMap = Dict<CompileBenchmarkMetadata>;
 
@@ -95,6 +96,7 @@ export interface CompileBenchmarkComparison {
  profile: Profile;
  scenario: string;
  backend: CodegenBackend;
+ target: Target;
  comparison: StatComparison;
 }
 
@@ -103,6 +105,7 @@ export interface CompileTestCase {
  profile: Profile;
  scenario: string;
  backend: CodegenBackend;
+ target: Target;
  category: Category;
 }
 
@@ -198,6 +201,7 @@ export function computeCompileComparisonsWithNonRelevant(
  profile: c.profile,
  scenario: c.scenario,
  backend: c.backend,
+ target: c.target,
  category: (benchmarkMap[c.benchmark] || {}).category || "secondary",
  };
  return calculateComparison(c.comparison, testCase);
@@ -242,18 +246,20 @@ export function transformDataForBackendComparison(
  cranelift: number | null;
  benchmark: string;
  profile: Profile;
+ target: Target;
  scenario: string;
  }
  > = new Map();
  for (const comparison of comparisons) {
- const key = `${comparison.benchmark};${comparison.profile};${comparison.scenario}`;
+ const key = `${comparison.benchmark};${comparison.profile};${comparison.scenario};${comparison.target}`;
  if (!benchmarkMap.has(key)) {
  benchmarkMap.set(key, {
  llvm: null,
  cranelift: null,
  benchmark: comparison.benchmark,
  profile: comparison.profile,
  scenario: comparison.scenario,
+ target: comparison.target,
  });
  }
  const record = benchmarkMap.get(key);
@@ -271,6 +277,7 @@ export function transformDataForBackendComparison(
  scenario: entry.scenario,
  // Treat LLVM as the baseline
  backend: "llvm",
+ target: entry.target,
  comparison: {
  statistics: [entry.llvm, entry.cranelift],
  is_relevant: true,

site/src/api.rs

@@ -332,6 +332,7 @@ pub mod comparison {
  pub profile: String,
  pub scenario: String,
  pub backend: String,
+ pub target: String,
  pub comparison: StatComparison,
  }
 

site/src/comparison.rs

@@ -11,6 +11,7 @@ use collector::Bound;
 use database::{
  metric::Metric,
  selector::{self, BenchmarkQuery, CompileBenchmarkQuery, RuntimeBenchmarkQuery, TestCase},
+ Target,
 };
 use database::{ArtifactId, Benchmark, Lookup, Profile, Scenario};
 use serde::Serialize;
@@ -152,6 +153,7 @@ pub async fn handle_compare(
  profile: comparison.profile.to_string(),
  scenario: comparison.scenario.to_string(),
  backend: comparison.backend.to_string(),
+ target: comparison.target.to_string(),
  comparison: comparison.comparison.into(),
  })
  .collect();
@@ -742,6 +744,7 @@ async fn compare_given_commits(
  scenario: test_case.scenario,
  benchmark: test_case.benchmark,
  backend: test_case.backend,
+ target: test_case.target,
  comparison,
  },
  )
@@ -1315,6 +1318,7 @@ pub struct CompileTestResultComparison {
  profile: Profile,
  scenario: Scenario,
  backend: CodegenBackend,
+ target: Target,
  comparison: TestResultComparison,
 }