Skip to content

Conversation

@chordowl
Copy link
Contributor

This fixes headings reading "Unsafety" and "Example", they should be "Safety" and "Examples" according to RFC 1574.

r? @steveklabnik

Copy link
Contributor

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! I have one change that's related, but not exactly this issue; if you think it shouldn't be done in this PR, then r=me, otherwise, r=me once the two extra #s are gone 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have only one #; mind doing that while you're here?

This fixes headings reading "Unsafety" and "Example", they should be "Safety" and "Examples" according to RFC 1574.
@chordowl
Copy link
Contributor Author

Done!

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

thanks a ton!

@bors
Copy link
Collaborator

bors commented Aug 24, 2017

📌 Commit 49ee9f3 has been approved by steveklabnik

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 25, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 26, 2017
…labnik Fix inconsistent doc headings This fixes headings reading "Unsafety" and "Example", they should be "Safety" and "Examples" according to RFC 1574. r? @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 26, 2017
…labnik Fix inconsistent doc headings This fixes headings reading "Unsafety" and "Example", they should be "Safety" and "Examples" according to RFC 1574. r? @steveklabnik
bors added a commit that referenced this pull request Aug 26, 2017
Rollup of 7 pull requests - Successful merges: #43776, #43966, #43979, #44072, #44086, #44090, #44091 - Failed merges:
@bors bors merged commit 49ee9f3 into rust-lang:master Aug 26, 2017
@chordowl chordowl deleted the fix-doc-headings branch August 26, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

4 participants