prefer hyphens in test files named after issue numbers #38473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We have a lot of tests with filenames honoring particular issues by number. Typically, these are called issue-${issue_no}.rs (note the hyphen): ``` $ find . -regextype posix-egrep -regex '.*/issue-[0-9]*.rs' | wc 1289 1289 35935 ``` We also had a much smaller number of files that are like this, but don't have a hyphen in between the substring `issue` and the number: ``` $ find . -regextype posix-egrep -regex '.*/issue[0-9]*.rs' ./debuginfo/issue14411.rs ./debuginfo/issue12886.rs ./debuginfo/issue13213.rs ./debuginfo/issue22656.rs ./debuginfo/issue7712.rs ./compile-fail/issue32829.rs ./run-pass/issue24353.rs ./run-pass/issue34796.rs ./run-pass/issue18173.rs ./run-pass/issue22346.rs ./run-pass/auxiliary/issue13507.rs ./run-pass/issue26127.rs ./run-pass/issue22008.rs ./run-pass/issue34569.rs ./run-pass/issue29927.rs ./run-pass/issue36260.rs ``` Some would argue that the inconsistency is æsthetically displeasing, hence this trivial patch. (Note that run-pass/auxiliary/issue13507.rs has an excuse; it's `use`d in run-pass/issue-13507-2.rs; the matter of there being two different compile-fail tests with different name conventions for issue rust-lang#32829 is also neglected here for the sake of keeping this trivial cleanup patch as trivial as possible for ease of review.) 
Contributor
| (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
| There are also |
Member
| Also |
Contributor
| @bors r+ rollup You are welcome to do |
Collaborator
| 📌 Commit 63cfedb has been approved by |
Collaborator
bors added a commit that referenced this pull request Jan 3, 2017
prefer hyphens in test files named after issue numbers We have a lot of tests with filenames honoring particular issues by number. Typically, these are called issue-${issue_no}.rs (note the hyphen): ``` $ find . -regextype posix-egrep -regex '.*/issue-[0-9]*.rs' | wc 1289 1289 35935 ``` We also had a much smaller number of files that are like this, but don't have a hyphen in between the substring `issue` and the number: ``` $ find . -regextype posix-egrep -regex '.*/issue[0-9]*.rs' ./debuginfo/issue14411.rs ./debuginfo/issue12886.rs ./debuginfo/issue13213.rs ./debuginfo/issue22656.rs ./debuginfo/issue7712.rs ./compile-fail/issue32829.rs ./run-pass/issue24353.rs ./run-pass/issue34796.rs ./run-pass/issue18173.rs ./run-pass/issue22346.rs ./run-pass/auxiliary/issue13507.rs ./run-pass/issue26127.rs ./run-pass/issue22008.rs ./run-pass/issue34569.rs ./run-pass/issue29927.rs ./run-pass/issue36260.rs ``` Some would argue that the inconsistency is æsthetically displeasing, hence this trivial patch. (Note that run-pass/auxiliary/issue13507.rs has an excuse; it's `use`d in run-pass/issue-13507-2.rs; the matter of there being two different compile-fail tests with different name conventions for issue no. 32829 is also neglected here for the sake of keeping this trivial cleanup patch as trivial as possible for ease of review.) Collaborator
| ☀️ Test successful - status-appveyor, status-travis |
zackmdavis added a commit to zackmdavis/rust that referenced this pull request Feb 5, 2017
Thanks to @nagisa for pointing these out (rust-lang#38473 (comment)).
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…oogaloo, r=petrochenkov continue to prefer hyphens in test files named after issue numbers a [followup](rust-lang#38473 (comment)) to rust-lang#38473 (The files in `auxillary/` directories have an excuse, as they get used as crates/modules, for which snake_case names make more sense.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have a lot of tests with filenames honoring particular issues by
number. Typically, these are called issue-${issue_no}.rs (note the
hyphen):
We also had a much smaller number of files that are like this, but don't
have a hyphen in between the substring
issueand the number:Some would argue that the inconsistency is æsthetically displeasing,
hence this trivial patch. (Note that run-pass/auxiliary/issue13507.rs
has an excuse; it's
used in run-pass/issue-13507-2.rs; the matter ofthere being two different compile-fail tests with different name
conventions for issue no. 32829 is also neglected here for the sake of
keeping this trivial cleanup patch as trivial as possible for ease of
review.)