Undo whitespace tweaks pending libbacktrace merge #30687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These should probably be submitted upstream. They're inevitably going to complicate merges, and because they're non-functional changes this just isn't worth our time.
Member
| @bors r+ |
Collaborator
| 📌 Commit 810c035 has been approved by |
Member
| @bors r- Maybe we should wait on https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00063.html. |
Contributor Author
| Agreed. I'll be far from shocked if that patch is ignored or rejected, but it's worth a shot. |
| Sorry to see that these changes were causing issues :(, FWIW I'm entirely okay with them being reverted. @mmcco Thank you for sending that patch and CCing me, I've posted some additional information about it to the thread. |
Contributor Author
| At this point, I think we should merge this PR and reapply the whitespace fixes if upstream eventually accepts them. When that happens, I'll submit a PR to pull new changes from upstream. |
Member
| @bors r+ rollup |
Collaborator
| 📌 Commit 810c035 has been approved by |
nagisa added a commit to nagisa/rust that referenced this pull request Jan 11, 2016
These should probably be submitted upstream. They're inevitably going to complicate merges, and because they're non-functional changes this just isn't worth our time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These should probably be submitted upstream. They're inevitably going to
complicate merges, and because they're non-functional changes this just
isn't worth our time.