Remove redundant clone

Author: sinkuu

src/bootstrap/dist.rs

@@ -1447,8 +1447,8 @@ impl Step for Extended {
  tarballs.extend(rls_installer.clone());
  tarballs.extend(clippy_installer.clone());
  tarballs.extend(rustfmt_installer.clone());
- tarballs.extend(llvm_tools_installer.clone());
- tarballs.extend(lldb_installer.clone());
+ tarballs.extend(llvm_tools_installer);
+ tarballs.extend(lldb_installer);
  tarballs.push(analysis_installer);
  tarballs.push(std_installer);
  if builder.config.docs {

src/bootstrap/test.rs

@@ -1052,7 +1052,7 @@ impl Step for Compiletest {
  let hostflags = flags.clone();
  cmd.arg("--host-rustcflags").arg(hostflags.join(" "));
 
- let mut targetflags = flags.clone();
+ let mut targetflags = flags;
  targetflags.push(format!(
  "-Lnative={}",
  builder.test_helpers_out(target).display()

src/librustc/infer/outlives/obligations.rs

@@ -458,7 +458,7 @@ where
  );
  debug!("projection_must_outlive: unique declared bound appears in trait ref");
  self.delegate
- .push_sub_region_constraint(origin.clone(), region, unique_bound);
+ .push_sub_region_constraint(origin, region, unique_bound);
  return;
  }
 

src/librustc/infer/region_constraints/mod.rs

@@ -749,7 +749,7 @@ impl<'tcx> RegionConstraintCollector<'tcx> {
  a // LUB(a,a) = a
  }
 
- _ => self.combine_vars(tcx, Lub, a, b, origin.clone()),
+ _ => self.combine_vars(tcx, Lub, a, b, origin),
  }
  }
 
@@ -771,7 +771,7 @@ impl<'tcx> RegionConstraintCollector<'tcx> {
  a // GLB(a,a) = a
  }
 
- _ => self.combine_vars(tcx, Glb, a, b, origin.clone()),
+ _ => self.combine_vars(tcx, Glb, a, b, origin),
  }
  }
 

src/librustc/traits/error_reporting.rs

@@ -239,7 +239,7 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
 
  let msg = format!("type mismatch resolving `{}`", predicate);
  let error_id = (DiagnosticMessageId::ErrorId(271),
- Some(obligation.cause.span), msg.clone());
+ Some(obligation.cause.span), msg);
  let fresh = self.tcx.sess.one_time_diagnostics.borrow_mut().insert(error_id);
  if fresh {
  let mut diag = struct_span_err!(
@@ -379,7 +379,7 @@ impl<'a, 'gcx, 'tcx> InferCtxt<'a, 'gcx, 'tcx> {
  }
  }
  if let Some(t) = self.get_parent_trait_ref(&obligation.cause.code) {
- flags.push(("parent_trait".to_owned(), Some(t.to_string())));
+ flags.push(("parent_trait".to_owned(), Some(t)));
  }
 
  if let Some(k) = obligation.cause.span.compiler_desugaring_kind() {

src/librustc/traits/project.rs

@@ -594,7 +594,7 @@ fn opt_normalize_projection_type<'a, 'b, 'gcx, 'tcx>(
 
  // But for now, let's classify this as an overflow:
  let recursion_limit = *selcx.tcx().sess.recursion_limit.get();
- let obligation = Obligation::with_depth(cause.clone(),
+ let obligation = Obligation::with_depth(cause,
  recursion_limit,
  param_env,
  projection_ty);

src/librustc/ty/context.rs

@@ -1200,7 +1200,7 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> {
  cstore,
  global_arenas: &arenas.global,
  global_interners: interners,
- dep_graph: dep_graph.clone(),
+ dep_graph,
  types: common_types,
  trait_map,
  export_map: resolutions.export_map.into_iter().map(|(k, v)| {

src/librustc_borrowck/borrowck/mod.rs

@@ -695,7 +695,7 @@ impl<'a, 'tcx> BorrowckCtxt<'a, 'tcx> {
  let mut err = self.cannot_act_on_moved_value(use_span,
  verb,
  msg,
- Some(nl.to_string()),
+ Some(nl),
  Origin::Ast);
  let need_note = match lp.ty.sty {
  ty::Closure(id, _) => {

src/librustc_borrowck/borrowck/move_data.rs

@@ -347,7 +347,7 @@ impl<'a, 'tcx> MoveData<'tcx> {
  lp = base_lp.clone();
  }
 
- self.add_move_helper(tcx, orig_lp.clone(), id, kind);
+ self.add_move_helper(tcx, orig_lp, id, kind);
  }
 
  fn add_move_helper(&self, tcx: TyCtxt<'a, 'tcx, 'tcx>,
@@ -359,7 +359,7 @@ impl<'a, 'tcx> MoveData<'tcx> {
  id,
  kind);
 
- let path_index = self.move_path(tcx, lp.clone());
+ let path_index = self.move_path(tcx, lp);
  let move_index = MoveIndex(self.moves.borrow().len());
 
  let next_move = self.path_first_move(path_index);
@@ -402,7 +402,7 @@ impl<'a, 'tcx> MoveData<'tcx> {
  }
  }
 
- self.add_assignment_helper(tcx, lp.clone(), assign_id, span);
+ self.add_assignment_helper(tcx, lp, assign_id, span);
  }
 
  fn add_assignment_helper(&self, tcx: TyCtxt<'a, 'tcx, 'tcx>,

src/librustc_codegen_llvm/base.rs

@@ -784,7 +784,7 @@ pub fn codegen_crate<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
  !tcx.sess.opts.output_types.should_codegen() {
  let ongoing_codegen = write::start_async_codegen(
  tcx,
- time_graph.clone(),
+ time_graph,
  metadata,
  rx,
  1);